Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Recycled LedgerEntryImpl instances are corrupted due to invalid recycling in BK client #3104

Closed
lhotari opened this issue Mar 14, 2022 · 4 comments
Closed

Recycled LedgerEntryImpl instances are corrupted due to invalid recycling in BK client #3104

lhotari opened this issue Mar 14, 2022 · 4 comments
Labels
type/bug

Comments

@lhotari
Copy link
Member

lhotari commented Mar 14, 2022 •
edited
Loading

BUG REPORT

Describe the bug

See apache/pulsar#14436 (comment) for a detailed analysis by @congbobo184 about the symptoms of the thread safety issue.

To Reproduce

Steps to reproduce the behavior:
Follow instructions in apache/pulsar#14436

Expected behavior

BK client should handle LedgerEntryImpl instances correctly so that it would prevent the issue where entries are used in 2 threads concurrently, perhaps due to "double recycling".
This was referenced Mar 14, 2022
Closed
Merged
Closed
@eolivelli
Copy link
Contributor

eolivelli commented Mar 14, 2022 •
edited
Loading

Makes sense to me.
I am fine with reverting #1792

data corruption is a bad problem, "being faster" is only an enhancement.

we should revert that change on master branch and on other active branches and possibly cut a new release

@eolivelli eolivelli mentioned this issue Mar 14, 2022
Closed
@eolivelli
Copy link
Contributor

eolivelli commented Mar 14, 2022 •
edited
Loading

PR for the revert:
#3106

great work @lhotari @congbobo1984

@lhotari lhotari changed the title Recycled LedgerEntryImpl instances are corrupted due to a thread safety issue in BK client Recycled LedgerEntryImpl instances are corrupted due to a invalid state handling in BK client Mar 15, 2022
@lhotari lhotari changed the title Recycled LedgerEntryImpl instances are corrupted due to a invalid state handling in BK client Recycled LedgerEntryImpl instances are corrupted due to invalid state handling in BK client Mar 15, 2022
@lhotari
Copy link
Member Author

lhotari commented Mar 15, 2022

This will be fixed by #3110

@lhotari lhotari changed the title Recycled LedgerEntryImpl instances are corrupted due to invalid state handling in BK client Recycled LedgerEntryImpl instances are corrupted due to invalid recycling in BK client Mar 15, 2022
@lhotari
Copy link
Member Author

lhotari commented Apr 8, 2022

Fixed by #3110

@lhotari lhotari closed this as completed Apr 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
type/bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@lhotari @eolivelli