Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standardize the check process of bookkeeper's workflow like pulsar project #3447

Closed
StevenLuMT opened this issue Aug 17, 2022 · 3 comments
Closed

Comments

@StevenLuMT
Copy link
Contributor

StevenLuMT commented Aug 17, 2022

TestTLS.testConnectToLocalTLSClusterTLSClient can't run all successfully in branch master and 4.15.1-rc0,
it seems that this problem has appeared long ago, rather than being introduced separately in this 4.15.1-rc0

this picture is the result for 4.15.1-rc0's testcase result:
image

this picture is the result for master's testcase result:
image

As for why the testcase run failed,it's caused by #3310 , we can revert #3310 or fix the bug
but I think it is necessary to standardize the check process of bookkeeper's workflow like pulsar project
change some checks to required instead of artificially strong merge

for example pr #3435 's workflow run failed, but be merged
image

this picture is bookkeeper's workflow check,no check is required:
image

this picture is pulsar's workflow check,checks are required:
image

@zymap
Copy link
Member

zymap commented Aug 18, 2022

#3439
this PR is for this

@StevenLuMT
Copy link
Contributor Author

#3439 #3451 and #3453
fix for this

@nicoloboschi
Copy link
Contributor

@zymap @StevenLuMT I guess we can close this issue now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants