Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide a #forceRecovery method in BookKeeperAdmin #783

Open
sijie opened this issue Nov 28, 2017 · 4 comments
Open

Provide a #forceRecovery method in BookKeeperAdmin #783

sijie opened this issue Nov 28, 2017 · 4 comments

Comments

@sijie
Copy link
Member

sijie commented Nov 28, 2017

FEATURE REQUEST

  1. Please describe the feature you are requesting.

Currently distributedlog tool provides a command for force-recovering a ledger (even the ledger is already closed). distributedlog achieves this by using some package private method in LedgerHandle. It would be good to add this method in BookKeeperAdmin for administration. so distributedlog can get rid of using package private method in LedgerHandle.

  1. Indicate the importance of this issue to you (blocker, must-have, should-have, nice-to-have). Are you currently using any workarounds to address this issue?

should-have

  1. Provide any additional detail on your proposed use case for this feature.

N/A

@ivankelly
Copy link
Contributor

Why does it need to do it if the ledger is already closed?

@sijie
Copy link
Member Author

sijie commented Nov 28, 2017

@ivankelly this was an admin tool to handle production issues when there was bug in bookkeeper recovery.

@ivankelly
Copy link
Contributor

👍 out of interest, do you recall what the bug was?

@sijie
Copy link
Member Author

sijie commented Nov 29, 2017

@ivankelly it was the bug in ledger recovery - it recorded the wrong last entry id. it was 2-3 years ago, I can't remember what exactly was that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants