Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Possibly moving Integration tests in a separated repository? #746

Closed
oscerd opened this issue Nov 26, 2020 · 8 comments
Closed

Possibly moving Integration tests in a separated repository? #746

oscerd opened this issue Nov 26, 2020 · 8 comments
Labels
Milestone

Comments

@oscerd
Copy link
Contributor

oscerd commented Nov 26, 2020

At some point we may end up having a lot of IT tests that may slow down the build. We may maintain just a subset of IT Tests in that case in main repo and moving the other in a different repo. What's your thought on this @valdar @orpiske ?

@orpiske
Copy link
Contributor

orpiske commented Nov 26, 2020

I agree that at this point they are already taking far too long to run.

However, I'd possibly keep them in this repo. I think we need to start filtering some slow tests in such a way that they can be enabled at will.

With junit 5 we can annotate the tests with

@EnabledIfSystemProperty(named = "enable.tests.slow", matches = "true")

Then, we can enable those tests when needed by using mvn -Denable.tests.slow=true ...

Keeping them separate makes it a bit hard for writing, debugging and test automation IMHO.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 26, 2020

Sounds good, but we need to track down the slow ones.

@orpiske
Copy link
Contributor

orpiske commented Nov 26, 2020

Agreed. I think I have some data about these. I'll try to share today or tomorrow.

@valdar
Copy link
Member

valdar commented Nov 26, 2020

+1 on leaving the tests on the same repo and have a way to enable them. I am not sure if a opt in or opt out approach is better though...

@orpiske
Copy link
Contributor

orpiske commented Nov 27, 2020

Screenshot_2020-11-27 camel-kafka-connector #246 Test Results  Jenkins (1)

This is the duration report from a personal CI I have, which runs the tests in multiple configurations (JDKs, w/ Strimzi, Salesforce tests, etc). AWS ones seems to be very big offenders in terms of test duration.

IMHO, we could probably leave them for running only on Apache CI. My vote would be for a explicit opt-in (via -Denable.tests.slow=true) and I can send a proposal PR later today if you all agree @valdar, @oscerd and anyone else that would like to step in and comment.

@oscerd
Copy link
Contributor Author

oscerd commented Nov 27, 2020

+1 for this approach

@orpiske
Copy link
Contributor

orpiske commented Nov 27, 2020

Thanks!

Let's see how it goes: #749

@oscerd
Copy link
Contributor Author

oscerd commented Dec 10, 2020

I think this is ok through #749

@oscerd oscerd closed this as completed Dec 10, 2020
@oscerd oscerd added this to the 0.7.0 milestone Jan 29, 2021
@oscerd oscerd added the 0.7.0 label Jan 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants