-
Notifications
You must be signed in to change notification settings - Fork 99
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possibly moving Integration tests in a separated repository? #746
Comments
I agree that at this point they are already taking far too long to run. However, I'd possibly keep them in this repo. I think we need to start filtering some slow tests in such a way that they can be enabled at will. With junit 5 we can annotate the tests with
Then, we can enable those tests when needed by using Keeping them separate makes it a bit hard for writing, debugging and test automation IMHO. |
Sounds good, but we need to track down the slow ones. |
Agreed. I think I have some data about these. I'll try to share today or tomorrow. |
+1 on leaving the tests on the same repo and have a way to enable them. I am not sure if a opt in or opt out approach is better though... |
This is the duration report from a personal CI I have, which runs the tests in multiple configurations (JDKs, w/ Strimzi, Salesforce tests, etc). AWS ones seems to be very big offenders in terms of test duration. IMHO, we could probably leave them for running only on Apache CI. My vote would be for a explicit opt-in (via -Denable.tests.slow=true) and I can send a proposal PR later today if you all agree @valdar, @oscerd and anyone else that would like to step in and comment. |
+1 for this approach |
Thanks! Let's see how it goes: #749 |
I think this is ok through #749 |
At some point we may end up having a lot of IT tests that may slow down the build. We may maintain just a subset of IT Tests in that case in main repo and moving the other in a different repo. What's your thought on this @valdar @orpiske ?
The text was updated successfully, but these errors were encountered: