Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Azure Eventhubs Sink - partition parameter #1005

Closed
tplevko opened this issue Aug 18, 2022 · 1 comment · Fixed by #1039
Closed

Azure Eventhubs Sink - partition parameter #1005

tplevko opened this issue Aug 18, 2022 · 1 comment · Fixed by #1039
Milestone

Comments

@tplevko
Copy link
Contributor

tplevko commented Aug 18, 2022

The partition parameter in Azure Eventhub Sink in the last version is specified as:

The Kamelet checks for the `partition` / `ce-partition` header to determine how long an event remains in the Azure Storage queue. Use `PnDTnHnMn.nS.` format. For example, `PT20.345S` parses as 20.345 seconds and `P2D` parses as 2 days.

This is IMHO counterintuitive, as the partition_key and partition_id in the Azure Eventhub Camel component is used for different purpose.

Could the name of the parameter be improved to something more descriptive?
Also - could be used the partition parameter for specifying the partition to be used by the kamelet, as in the Azure Eventhub Camel component?

@oscerd oscerd added this to the 0.10.0 milestone Aug 26, 2022
@oscerd
Copy link
Contributor

oscerd commented Sep 12, 2022

For the first question yes, we can name the parameter in a different way. For having partitionId as parameter of Kamelet, I don't agree totally, it's something that makes much more sense to have as dynamic parameter than fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants