Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Nats Kamelets: Mark servers as secret parameter since it could contains sensitive data if authenticated #1086

Closed
oscerd opened this issue Oct 12, 2022 · 1 comment · Fixed by #1140
Closed

Nats Kamelets: Mark servers as secret parameter since it could contains sensitive data if authenticated #1086

oscerd opened this issue Oct 12, 2022 · 1 comment · Fixed by #1140
Milestone
0.10.0

Comments

@oscerd
Copy link
Contributor

oscerd commented Oct 12, 2022

@chrisdutz from the discussion in dev.
@oscerd oscerd added this to the 0.10.0 milestone Oct 12, 2022
@oscerd
Copy link
Contributor Author

oscerd commented Nov 7, 2022

We already have the needed bits in place. Since in servers parameters you might have multiple servers with different username and password, the easier solution would be to label the parameter as secret so it will be masked in logs.

@oscerd oscerd changed the title Add Nats Source and Sink Kamelets specialized for Authenticated NATS Server Nats Kamelets: Mark servers as secret parameter since it could contains sensitive data if authenticated Nov 7, 2022
This was referenced Nov 7, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.10.0
1 participant
@oscerd