Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

google-storage-sink serviceAccountKey is not required #1203

Closed
brokenjacobs opened this issue Dec 6, 2022 · 8 comments · Fixed by #1206
Closed

google-storage-sink serviceAccountKey is not required #1203

brokenjacobs opened this issue Dec 6, 2022 · 8 comments · Fixed by #1206
Assignees
Milestone

Comments

@brokenjacobs
Copy link

Google supports the ADC (Application Default Credentials) process for applications hosted on their platform.
https://cloud.google.com/docs/authentication/application-default-credentials

This field is not necessary unless the kamelet is running outside of GCP/GKE. You can use Workload Identity together with ADC to authenticate without a keyfile. The google libraries do this automatically.

Thanks!

@oscerd
Copy link
Contributor

oscerd commented Dec 6, 2022

Kamelets could run even outside gcp/gke. But we could relax the requirement on serviceAccountKey as required parameter.

@oscerd oscerd added this to the 0.11.0 milestone Dec 6, 2022
@oscerd oscerd self-assigned this Dec 6, 2022
@oscerd oscerd removed this from the 0.11.0 milestone Dec 7, 2022
@oscerd
Copy link
Contributor

oscerd commented Dec 7, 2022

It's harder than what I thought. We are enconding the service account key as base64, there is no way at this stage to have the parameter optional if we are prepeding base64 in front of it. For the moment it will stay as is.

@brokenjacobs
Copy link
Author

This greatly complicates deployment on GCP and requires keeping keyfiles around. The ADC process allows for keyfiles as well, it sounds like this implementation isn't compliant because of how the configuration is being fed in.

FWIW the old connector appears to work and have the setting as optional.

@oscerd
Copy link
Contributor

oscerd commented Dec 7, 2022

I created this on Camel core side to make it optional. https://issues.apache.org/jira/projects/CAMEL/issues/CAMEL-18802

@oscerd
Copy link
Contributor

oscerd commented Dec 7, 2022

The old connector was based on the pure component, the new ones have been based on Kamelet, a different concept.

@oscerd
Copy link
Contributor

oscerd commented Dec 7, 2022

By the way, thanks for reporting problems and improvements. This is highly appreciated. I hope we could have a fix for the next camel-kamelets release.

@oscerd
Copy link
Contributor

oscerd commented Dec 13, 2022

This will be in 0.11.0 and in ckc 3.20.0

@brokenjacobs
Copy link
Author

Thanks for tracking this down!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants