Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Can we remove the tectonic.ui crap #1700

Closed
davsclaus opened this issue Oct 21, 2023 · 13 comments · Fixed by #1736
Closed

Can we remove the tectonic.ui crap #1700

davsclaus opened this issue Oct 21, 2023 · 13 comments · Fixed by #1736
Assignees

Comments

@davsclaus
Copy link
Contributor

The kamelets should be clean and neutral.

All this kind of stuff should be removed.

    x-descriptors:
    - 'urn:alm:descriptor:com.tectonic.ui:checkbox'
@oscerd oscerd self-assigned this Oct 21, 2023
@oscerd
Copy link
Contributor

oscerd commented Oct 21, 2023

This was when Kamelets were associated only to camel k

@davsclaus
Copy link
Contributor Author

Maybe we can do a grep from terminal and find out approx how many x-descriptors there are to understand how big a work this is

@davsclaus
Copy link
Contributor Author

Some of them can be replaced with enum #1699

@lburgazzoli
Copy link
Contributor

some of those descriptors are leveraged by tools to i.e. show the properties on different places/wizard/whatnot.

the tectonic ones are leveraged by openshift's dev console so we may need to deprecate them before removing them

@oscerd
Copy link
Contributor

oscerd commented Oct 23, 2023

I think this affects also Karavan and Kaoto, because they are using Tekton.

@christophd
Copy link
Contributor

@Delawen @igarashitm 👀

@igarashitm
Copy link

We don't have any special use for that in Kaoto ATM

@mgubaidullin
Copy link
Contributor

Karavan does not use x-descriptors.

@oscerd
Copy link
Contributor

oscerd commented Oct 23, 2023

So it seems only the openshift dev console would be affected

@christophd
Copy link
Contributor

@vikram-raj could you please have a look and see how this would impact the ODC UI? many thanks

@christophd
Copy link
Contributor

maybe also @invincibleJai please have a look. thx!

@oscerd
Copy link
Contributor

oscerd commented Nov 14, 2023

@vikram-raj @invincibleJai please give feedback. I'm going to remove tectonic metadata next week.

@oscerd
Copy link
Contributor

oscerd commented Nov 15, 2023

Removed. If there is any needs, Kamelets could be enriched directly by project using them

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
6 participants