Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expose user-relevant options in kafka sources/sinks #247

Closed
nicolaferraro opened this issue May 6, 2021 · 8 comments
Closed

Expose user-relevant options in kafka sources/sinks #247

nicolaferraro opened this issue May 6, 2021 · 8 comments
Assignees

Comments

@nicolaferraro
Copy link
Member

I'm thinking to:

  • clientId
  • autoOffsetReset

But there may be others.

We can use the new optional placeholder for the clientId.

@oscerd oscerd self-assigned this May 6, 2021
@oscerd
Copy link
Contributor

oscerd commented May 10, 2021

I think for the source side, it's important to specify the pollOnError option, to specify how to behave in case of fail while polling one message.

@oscerd
Copy link
Contributor

oscerd commented May 10, 2021

Also allowManualCommit and autoCommitEnable should be exposed in some way.

@nicolaferraro
Copy link
Member Author

Also allowManualCommit and autoCommitEnable should be exposed in some way.

Yes, we should also provide a way to do manual commit in case (e.g. an action).

@nicolaferraro
Copy link
Member Author

I think for the source side, it's important to specify the pollOnError option, to specify how to behave in case of fail while polling one message.

Is there some relation to error handler? cc: @squakez

@oscerd
Copy link
Contributor

oscerd commented May 10, 2021

It's the default, but you may also specify ignore record and go ahead, retry or reconnect.

@oscerd
Copy link
Contributor

oscerd commented May 10, 2021

So we can maintain the default but also give freedom to the end user.

@squakez
Copy link
Contributor

squakez commented May 11, 2021

I think for the source side, it's important to specify the pollOnError option, to specify how to behave in case of fail while polling one message.

Is there some relation to error handler? cc: @squakez

The errorHandler, if configured by user, is taking over when an exception arise either in the source or the sink. If there is some error managment done by the Kamelet, then, the errorHandler should not be triggered. However it would be good to double check these kind of behaviors.

@oscerd
Copy link
Contributor

oscerd commented May 12, 2021

So now we have:

  • autoCommitEnable
  • allowManualCommit
  • autoOffsetReset
  • pollOnError

For clientId as optional, we need Camel 3.10

@oscerd oscerd closed this as completed Mar 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants