Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move kamelets from root folder into a sub folder #448

Closed
davsclaus opened this issue Jul 27, 2021 · 7 comments · Fixed by #583
Closed

Move kamelets from root folder into a sub folder #448

davsclaus opened this issue Jul 27, 2021 · 7 comments · Fixed by #583

Comments

@davsclaus
Copy link
Contributor

There are soo many kamelets now it would be good to move them into their own sub folder, as we also have code for other stuff like the catalog api, and whatnot.

That helps the structure a bit, and also to look at the project on github as the readme file is shown sooner, than having to scroll long way down.

@davsclaus
Copy link
Contributor Author

Need to talk to @lburgazzoli if this wont affect camel-k, as then the github url for the kamelet file would be changed.
also camel-kamelet-main needs to be aware as it also downloads from the root via github urls

Just created a ticket to find a way to organize the yaml files in a better way

@oscerd
Copy link
Contributor

oscerd commented Nov 25, 2021

I'm planning to start working on this. @lburgazzoli @nicolaferraro can you please show reference of kamelet.yaml files path in the camel-k codebase? So I'll do multiple PRs in one time. Thanks.

@oscerd
Copy link
Contributor

oscerd commented Nov 25, 2021

@davsclaus Can you show reference in main Camel repo? Thanks.

@davsclaus
Copy link
Contributor Author

You can find some of it via

git grep "github:apache:camel-kamelets"

@davsclaus
Copy link
Contributor Author

We use the
https://github.com/apache/camel/tree/main/components/camel-resourceresolver-github

to download the official kamelets when using camel-jbang / camel-kamelet-main. And I think its only a matter of configuring the url location, from the previous comment.

However if they are located in different sub folders, then we cannot know where to look.

@oscerd
Copy link
Contributor

oscerd commented Nov 25, 2021

I think it would be enough to have just one subfolder with all the yamls

@oscerd
Copy link
Contributor

oscerd commented Nov 25, 2021

No multiple subfolders for the moment

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants