Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add a "namespace" label to help group kamelets #640

Closed
lburgazzoli opened this issue Dec 17, 2021 · 6 comments · Fixed by #1302
Closed

Add a "namespace" label to help group kamelets #640

lburgazzoli opened this issue Dec 17, 2021 · 6 comments · Fixed by #1302
Assignees
Milestone

Comments

@lburgazzoli
Copy link
Contributor

As today we have a kamelet.group label that is used to group related kamelets together:

camel.apache.org/kamelet.group: "AWS Cloudwatch"

It would be nice to add an additional label to define a larger group of related kamelets, like kamelet.namespace:

camel.apache.org/kamelet.namespace: "aws"
@lburgazzoli
Copy link
Contributor Author

/cc @nicolaferraro @oscerd

@oscerd
Copy link
Contributor

oscerd commented Dec 17, 2021

Makes sense

@lburgazzoli lburgazzoli self-assigned this Dec 17, 2021
@lburgazzoli
Copy link
Contributor Author

or maybe review how the group is used and i.e instead of AWS Cloudwatch, just use AWS ?

@oscerd
Copy link
Contributor

oscerd commented Dec 17, 2021

Originally it was done in that way because if we had multiple kamelets for the same AWS service, they would have been filtered in the site view. But yeah, makes sense too

@lburgazzoli
Copy link
Contributor Author

or maybe we can use a convention like kamelet.group is always like namespace [+ kind] so in the case of AWS Cloudwatch,

namespace = AWS
kind = Cloudwatch

@oscerd
Copy link
Contributor

oscerd commented Dec 17, 2021

I think it should work in this way, I'm not sure if the annotations are currently used in camel-k too, need to have a look.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants