Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split Github Source Kamelet in multiple Kamelets #648

Closed
oscerd opened this issue Dec 21, 2021 · 2 comments · Fixed by #668
Closed

Split Github Source Kamelet in multiple Kamelets #648

oscerd opened this issue Dec 21, 2021 · 2 comments · Fixed by #668
Assignees
@oscerd

Comments

@oscerd
Copy link
Contributor

oscerd commented Dec 21, 2021

I think it makes sense to change the Github Source Kamelet, to have multiple Kamelets for different entities, like tag, pullRequest, pullRequestComment.

We'll have:

  • Fine grained configuration for Github consumer
  • Specific option, for example startingSha while consuming commit
  • Better catalog and better listing in Karavan

What do you think @davsclaus @lburgazzoli @nicolaferraro
@oscerd oscerd self-assigned this Dec 21, 2021
@lburgazzoli
Copy link
Contributor

+1

1 similar comment
@davsclaus
Copy link
Contributor

+1

This was referenced Dec 21, 2021
Merged
Merged
Merged
This was referenced Jan 3, 2022
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@oscerd oscerd

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed Github Source Kamelet apache/camel-kamelets
3 participants
@davsclaus @lburgazzoli @oscerd