Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Examples should have use Quarkus Main Application #1280

Closed
davsclaus opened this issue May 30, 2020 · 6 comments
Closed

Examples should have use Quarkus Main Application #1280

davsclaus opened this issue May 30, 2020 · 6 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@davsclaus
Copy link
Contributor

eg the new in 1.5 about QuarkusApplication as a main class so you can run it easily without having to use mvn quarkus:dev etc.

@lburgazzoli
Copy link
Contributor

@davsclaus
Copy link
Contributor Author

Thanks Luca, yeah so it seems its a bigger work but IMHO needed to make camel-quarkus as a more first class citizen in Quarkus. The command mode is going to be what users do, as its ala Spring Boot, and easy to reason about because there is a Main class of their own.

@lburgazzoli
Copy link
Contributor

lburgazzoli commented May 30, 2020

I do agree and the aim #1128 was exactly aimed to let user choose their preferred way of running camel. I do have some bits ready for the bootstrap thing but need a little bit of polishing, hope ot ave them ready before end of next week.

@lburgazzoli
Copy link
Contributor

lburgazzoli commented Jun 22, 2020

We have now an example that uses quarkus main

 https://github.com/apache/camel-quarkus/tree/master/examples/timer-log-main

however there's an issue quarkusio/quarkus#10147 that prevent to start it from the IDE.

@davsclaus do you think we should make most of the examples using the command mode ? once the issue is fixed of course :)

@davsclaus davsclaus added good first issue Good for newcomers help wanted Extra attention is needed labels Jan 28, 2021
@Delawen
Copy link

Delawen commented Sep 17, 2021

I can take a look at this. Should I migrate all examples or just a selection of them?

@jamesnetherton
Copy link
Contributor

Maybe this issue should be closed. mvn quarkus:dev is pretty much the standard dev workflow. Command mode is not.

IMO it's enough to have a single example that demonstrates the Quarkus command mode stuff. Which we already have here:

https://github.com/apache/camel-quarkus-examples/tree/main/timer-log-main

@ppalaga ppalaga closed this as completed Sep 19, 2021
@ppalaga ppalaga added this to the No fix/wont't fix milestone Sep 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

5 participants