Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Quarkus 1.6.1.Final] platform-http: dev mode breaking with log "Request has already been read" #1373

Closed
aldettinger opened this issue Jun 18, 2020 · 3 comments

Comments

@aldettinger
Copy link
Contributor

From a shell, execute:
watch -n 0.1 http :8080/count <<< '{count: 20}'

From another shell:
Create a simple http-platform route from("platform-http:/count").setBody(constant("count !"));
mvn quarkus:dev

Modify the route definition and save, quarkus hot-reload is triggerd but now the route crash from time to time with below stack trace:
2020-06-18 14:23:00,418 ERROR [io.qua.ver.htt.run.QuarkusErrorHandler] (vert.x-eventloop-thread-2) HTTP Request to /count failed, error id: 7e77ae31-d835-4e94-8226-6ba5e846307e-2: java.lang.IllegalStateException: Request has already been read at io.vertx.core.http.impl.HttpServerRequestImpl.checkEnded(HttpServerRequestImpl.java:591) at io.vertx.core.http.impl.HttpServerRequestImpl.handler(HttpServerRequestImpl.java:304) at io.quarkus.vertx.http.runtime.ResumingRequestWrapper.handler(ResumingRequestWrapper.java:18) at io.vertx.ext.web.impl.HttpServerRequestWrapper.handler(HttpServerRequestWrapper.java:79) at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:86) at io.vertx.ext.web.handler.impl.BodyHandlerImpl.handle(BodyHandlerImpl.java:42) at io.quarkus.vertx.http.runtime.VertxHttpRecorder$14.handle(VertxHttpRecorder.java:980) at io.quarkus.vertx.http.runtime.VertxHttpRecorder$14.handle(VertxHttpRecorder.java:953) at io.vertx.ext.web.impl.RouteState.handleContext(RouteState.java:1034) at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:131) at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:128) at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup.handleHotReplacementRequest(VertxHttpHotReplacementSetup.java:39) at io.vertx.ext.web.impl.RouteState.handleContext(RouteState.java:1034) at io.vertx.ext.web.impl.RoutingContextImplBase.iterateNext(RoutingContextImplBase.java:131) at io.vertx.ext.web.impl.RoutingContextImpl.next(RoutingContextImpl.java:128) at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:74) at io.quarkus.vertx.http.runtime.devmode.VertxHttpHotReplacementSetup$2.handle(VertxHttpHotReplacementSetup.java:63) at io.vertx.core.impl.ContextImpl.lambda$null$0(ContextImpl.java:330) at io.vertx.core.impl.ContextImpl.executeTask(ContextImpl.java:369) at io.vertx.core.impl.EventLoopContext.lambda$executeAsync$0(EventLoopContext.java:38) at io.netty.util.concurrent.AbstractEventExecutor.safeExecute(AbstractEventExecutor.java:164) at io.netty.util.concurrent.SingleThreadEventExecutor.runAllTasks(SingleThreadEventExecutor.java:472) at io.netty.channel.nio.NioEventLoop.run(NioEventLoop.java:500) at io.netty.util.concurrent.SingleThreadEventExecutor$4.run(SingleThreadEventExecutor.java:989) at io.netty.util.internal.ThreadExecutorMap$2.run(ThreadExecutorMap.java:74) at io.netty.util.concurrent.FastThreadLocalRunnable.run(FastThreadLocalRunnable.java:30) at java.base/java.lang.Thread.run(Thread.java:834)

@aldettinger
Copy link
Contributor Author

Must be an occurence of quarkus#9693, let's integrate the fix when available.

@jamesnetherton jamesnetherton changed the title plaforfm-http: dev mode breaking with log "Request has already been read" plaform-http: dev mode breaking with log "Request has already been read" Jul 8, 2020
@aldettinger aldettinger changed the title plaform-http: dev mode breaking with log "Request has already been read" platform-http: dev mode breaking with log "Request has already been read" Jul 9, 2020
@aldettinger
Copy link
Contributor Author

aldettinger commented Jul 9, 2020

quarkus#9693 should be fixed in quarkus 1.7 1.6.1.Final. Let's follow up on that one.

@ppalaga ppalaga changed the title platform-http: dev mode breaking with log "Request has already been read" [Quarkus 1.7] platform-http: dev mode breaking with log "Request has already been read" Jul 10, 2020
@aldettinger aldettinger changed the title [Quarkus 1.7] platform-http: dev mode breaking with log "Request has already been read" [Quarkus 1.6.1.Final] platform-http: dev mode breaking with log "Request has already been read" Aug 4, 2020
@aldettinger
Copy link
Contributor Author

So, it really was an occurrence of quarkus#9693. Since quarkus 1.6.1.Final, I couldn't reproduce anymore.

@ppalaga ppalaga added this to the No fix/wont't fix milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants