Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Camel 3.5] OpenTracing integration test fails with Camel 3.5.0-SNAPSHOT #1493

Closed
jamesnetherton opened this issue Jul 22, 2020 · 6 comments
Closed
Assignees
Labels
bug Something isn't working
Milestone

Comments

@jamesnetherton
Copy link
Contributor

Until now we seem to have avoided OpenTracing API incompatibilities between 0.31.0 (used by Quarkus) & 0.33.0 (used by Camel). The Camel OpenTracingTracer now invokes a method that is not present in 0.31.0, hence we see:

[INFO] Running org.apache.camel.quarkus.component.opentracing.it.OpenTracingTest
2020-07-22 09:34:37,146 INFO  [org.apa.cam.qua.cor.CamelBootstrapRecorder] (main) bootstrap runtime: org.apache.camel.quarkus.main.CamelMainRuntime
2020-07-22 09:34:37,184 INFO  [org.apa.cam.mai.BaseMainSupport] (main) Auto-configuration summary:
2020-07-22 09:34:37,185 INFO  [org.apa.cam.mai.BaseMainSupport] (main) 	camel.context.name=quarkus-camel-example
2020-07-22 09:34:37,205 INFO  [org.apa.cam.qua.mai.CamelMainRoutesCollector] (main) Loading additional Camel XML route templates from: classpath:camel-template/*.xml
2020-07-22 09:34:37,226 ERROR [io.qua.application] (main) Failed to start application: java.lang.NoSuchMethodError: 'boolean io.opentracing.util.GlobalTracer.registerIfAbsent(io.opentracing.Tracer)'
	at org.apache.camel.opentracing.OpenTracingTracer.registerGlobalTracer(OpenTracingTracer.java:234)
	at org.apache.camel.opentracing.OpenTracingTracer.doInit(OpenTracingTracer.java:228)
	at org.apache.camel.support.service.BaseService.init(BaseService.java:83)
	at org.apache.camel.support.service.ServiceHelper.initService(ServiceHelper.java:55)
	at org.apache.camel.impl.engine.AbstractCamelContext.internalAddService(AbstractCamelContext.java:1485)
	at org.apache.camel.impl.engine.AbstractCamelContext.addService(AbstractCamelContext.java:1403)
	at org.apache.camel.opentracing.OpenTracingTracer.init(OpenTracingTracer.java:126)
	at org.apache.camel.opentracing.OpenTracingTracer.createRoutePolicy(OpenTracingTracer.java:114)

AFAIK - Quarkus will not move to OpenTracing 0.33.x until MicroProfile OpenTracing is upgraded to 2.0.

@davsclaus
Copy link
Contributor

They are on 0.33 on their master branch
https://github.com/eclipse/microprofile-opentracing/blob/master/pom.xml#L38

@davsclaus
Copy link
Contributor

Maybe in the mean time we can make OpenTracingTracer in camel use the older api if its possible

@davsclaus
Copy link
Contributor

Quarkus 1.7 seems to be going with MP 1.3.3 that uses the older 0.31.0 version.

So we may look at making camel-opentracing use the older API if possible and then upgrade to 0.33+ later.

@davsclaus
Copy link
Contributor

This is only relevant when upgrading to Camel 3.5, and for quarkus 1.7 we can stay on camel 3.4.2 release.

@davsclaus
Copy link
Contributor

Okay we have dropped back to 0.31.0 version
https://issues.apache.org/jira/browse/CAMEL-15354

@jamesnetherton
Copy link
Contributor Author

I verified this is fixed with the latest Camel 3.5.0 SNAPSHOT.

@ppalaga ppalaga changed the title OpenTracing integration test fails with Camel 3.5.0-SNAPSHOT [Camel 3.5] OpenTracing integration test fails with Camel 3.5.0-SNAPSHOT Aug 10, 2020
@ppalaga ppalaga added this to the 1.1.0 milestone Aug 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants