Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding Changelog generated automatically through gh action #1772

Closed
oscerd opened this issue Sep 9, 2020 · 9 comments · Fixed by #1784
Closed

Adding Changelog generated automatically through gh action #1772

oscerd opened this issue Sep 9, 2020 · 9 comments · Fixed by #1784
Assignees
Milestone

Comments

@oscerd
Copy link
Contributor

oscerd commented Sep 9, 2020

We are using this gh action on camel-k, camel-k-runtime and camel-kafka-connector.

I think the result is really useful to track the activities.

Do we want to introduce it here too?

https://github.com/apache/camel-kafka-connector/blob/master/CHANGELOG.md

@oscerd oscerd self-assigned this Sep 9, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Sep 10, 2020

I see quite a lot of Updated CHANGELOG.md commits in the Kafka connector log https://github.com/apache/camel-kafka-connector/commits/master I must say, I'd prefer having as little commits of this kind as possible. Perhaps having one just before the release would be sufficient.
How is the action triggered?

@oscerd
Copy link
Contributor Author

oscerd commented Sep 10, 2020

On schedule each night

@oscerd
Copy link
Contributor Author

oscerd commented Sep 10, 2020

From a couple of days. Before it was done on each pr merged, issue closed etc

@ppalaga
Copy link
Contributor

ppalaga commented Sep 10, 2020

I see. I could live with one commit a day (if there is some activity on that day). But anyway, it would be handy to be able to trigger an update manually before cutting a release. Would something like that be possible?

@ppalaga
Copy link
Contributor

ppalaga commented Sep 10, 2020

... and yes, having a way to auto-assemble a change log is useful. Thanks for proposing it!

@oscerd
Copy link
Contributor Author

oscerd commented Sep 10, 2020

I never heard of possibility of running gh action manually but maybe @jamesnetherton knows more

@jamesnetherton
Copy link
Contributor

I never heard of possibility of running gh action manually but maybe @jamesnetherton knows more

I think you'd need to have a personal access token set up to do that.

One option could be to trigger the changelog action whenever a new tag is pushed.

@ppalaga
Copy link
Contributor

ppalaga commented Sep 10, 2020

One option could be to trigger the changelog action whenever a new tag is pushed.

I thought that would be too late for the new tag to appear in the change log, when the change log is referenced via the given tag. But apparently it works somehow for Kafka connector - release 0.5.0 is listed as of 'camel-kafka-connector-0.5.0' tag of the change log https://github.com/apache/camel-kafka-connector/blob/camel-kafka-connector-0.5.0/CHANGELOG.md
The workflow run preceding the tag knew somehow magically that the tag is going to happen apache/camel-kafka-connector@fe8aae3#diff-4ac32a78649ca5bdd8e0ba38b7006a1eR3
I wonder how is that possible?

@oscerd
Copy link
Contributor Author

oscerd commented Sep 10, 2020

The tag was created and then removed :-) because we had problem with the release

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants