Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Camel 3.7] Investigate reason of the explicit registration of some resources in CamelProcessor #1995

Closed
JiriOndrusek opened this issue Nov 5, 2020 · 1 comment
Milestone

Comments

@JiriOndrusek
Copy link
Contributor

There is a change in camel-quarkus (#1984) forced by the recent changes in camel (https://issues.apache.org/jira/browse/CAMEL-15784).

Addition of the following code into CamelProcessor seems unnecessary,

@buildstep
NativeImageResourceBuildItem initResources() {
return new NativeImageResourceBuildItem(
"META-INF/services/org/apache/camel/bean-processor-factory",
"META-INF/services/org/apache/camel/rest-registry-factory");
}

because there is a similar code already there:

@buildstep
void coreServicePatterns(BuildProducer services) { void coreServicePatterns(BuildProducer services) {
services.produce(new CamelServicePatternBuildItem( services.produce(new CamelServicePatternBuildItem(
CamelServiceDestination.REGISTRY, CamelServiceDestination.REGISTRY,
true, true,
"META-INF/services/org/apache/camel/component/", "META-INF/services/org/apache/camel/component/",
"META-INF/services/org/apache/camel/language/constant", "META-INF/services/org/apache/camel/language/constant",
"META-INF/services/org/apache/camel/language/file", "META-INF/services/org/apache/camel/language/file",
"META-INF/services/org/apache/camel/language/header", "META-INF/services/org/apache/camel/language/header",
"META-INF/services/org/apache/camel/language/ref", "META-INF/services/org/apache/camel/language/ref",
"META-INF/services/org/apache/camel/language/simple")); "META-INF/services/org/apache/camel/language/simple"));
services.produce(new CamelServicePatternBuildItem( services.produce(new CamelServicePatternBuildItem(
CamelServiceDestination.DISCOVERY, CamelServiceDestination.DISCOVERY,
true, true,
"META-INF/services/org/apache/camel/", "META-INF/services/org/apache/camel/",
"META-INF/services/org/apache/camel/management/", "META-INF/services/org/apache/camel/management/",
"META-INF/services/org/apache/camel/model/", "META-INF/services/org/apache/camel/model/",
"META-INF/services/org/apache/camel/configurer/", "META-INF/services/org/apache/camel/configurer/",
"META-INF/services/org/apache/camel/language/", "META-INF/services/org/apache/camel/language/",
"META-INF/services/org/apache/camel/dataformat/", "META-INF/services/org/apache/camel/dataformat/",
"META-INF/services/org/apache/camel/send-dynamic/", "META-INF/services/org/apache/camel/send-dynamic/",
"META-INF/services/org/apache/camel/urifactory/")); "META-INF/services/org/apache/camel/urifactory/"));
} }

Without this change, some integration tests (bean, slack, openpi-java and others) fails.

This change should be investigated properly.

@jamesnetherton jamesnetherton changed the title Investigate reason of the explicit registration of some resources in CamelProcessor [Camel 3.7] Investigate reason of the explicit registration of some resources in CamelProcessor Nov 11, 2020
@jamesnetherton jamesnetherton added this to the 1.5.0 milestone Nov 18, 2020
@ppalaga
Copy link
Contributor

ppalaga commented Dec 11, 2020

Fixed in the camel-master branch

@ppalaga ppalaga closed this as completed Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants