Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Micrometer: Router policy should be disabled by default (to be consistent with Camel) #5028

Open
JiriOndrusek opened this issue Jun 29, 2023 · 4 comments · May be fixed by #5247
Open

Micrometer: Router policy should be disabled by default (to be consistent with Camel) #5028

JiriOndrusek opened this issue Jun 29, 2023 · 4 comments · May be fixed by #5247
Assignees
Labels
area/micrometer bug Something isn't working

Comments

@JiriOndrusek
Copy link
Contributor

Bug description

As you can see in Camel documentation, RoutePolicyFactory is not enabled by default. CQ should be consistent with this behavior and change default value for property camel.metrics.enableRoutePolicy to false (code)

@JiriOndrusek JiriOndrusek added the bug Something isn't working label Jun 29, 2023
@JiriOndrusek JiriOndrusek self-assigned this Jun 29, 2023
@jamesnetherton
Copy link
Contributor

The docs state that the default is true:

https://camel.apache.org/components/3.20.x/micrometer-component.html#_sb_option_camel_metrics_enable-route-policy

@JiriOndrusek
Copy link
Contributor Author

JiriOndrusek commented Jun 29, 2023

Default is true for CSB, unfurtunately for plain Camel default is false. Because users have to set routePolicy, like in the test. (Explanation in the doc is From Java you just add the factory to the CamelContext as shown below: context.addRoutePolicyFactory(new MicrometerRoutePolicyFactory());

Therefore CQ should default to false and ticket should be reported for CSB also.

JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Jun 29, 2023
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Jun 29, 2023
@zhfeng
Copy link
Contributor

zhfeng commented Aug 16, 2023

@JiriOndrusek it can be closed? or is there anything about document we need to do?

@JiriOndrusek
Copy link
Contributor Author

@zhfeng thanks for noticing the issue!

TBH I still think that my previous comment is right.
Let me explain:

  • Micrometer Router policy in Camel is disabled by default, see documentation, following code has to be used to enable policy: context.addRoutePolicyFactory(new MicrometerRoutePolicyFactory());.
  • Micrometer Router policy in CSB is enabled by default, see documentation
  • Micrometer Router policy in CQ is currently enabled by default, but I think, that it should be disabled (and therefore disabled with plain Camel)

I'll prepare a PR which changes this behavior as I suggested above. Therefore we should keep this issue opened.

JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Sep 1, 2023
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Sep 1, 2023
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Sep 1, 2023
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Sep 1, 2023
JiriOndrusek added a commit to JiriOndrusek/camel-quarkus that referenced this issue Sep 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/micrometer bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants