Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Activate format profile as part of CI checks #6021

Closed
jamesnetherton opened this issue Apr 22, 2024 · 1 comment
Closed

Activate format profile as part of CI checks #6021

jamesnetherton opened this issue Apr 22, 2024 · 1 comment
Assignees
@jamesnetherton
Labels
housekeeping
Milestone
3.10.0

Comments

@jamesnetherton
Copy link
Contributor

Description

It's too easy to miss / forget to apply modifications to generated sources that the format profile applies.

We could validate this on CI by either:

  • Running the initial build with -Pformat

Or

  • Run a separate step for mvn process-resources -Pformat

Or

  • Do either of the above in the validate-pr workflow
@jamesnetherton jamesnetherton self-assigned this Apr 23, 2024
@jamesnetherton
Copy link
Contributor Author

I did this in #6027. Seems to be working ok across all workflows.

@jamesnetherton jamesnetherton added this to the 3.10.0 milestone Apr 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jamesnetherton jamesnetherton

Labels
housekeeping
Projects
None yet
Milestone
3.10.0
Development

No branches or pull requests
1 participant
@jamesnetherton