New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CAMEL-9145] update hbase version to 1.1.1 and hadoop2 to 2.7.1 #634
Conversation
This branch has conflicts that must be resolved Also do not use tabs for xml but spaces and why is the osgi range for this starting from 2 and not from 1 as before? |
oh, I haven't noticed the conflict. I'll try to resolve it. |
Conflicts: parent/pom.xml
I've made a merge and replaced all tabs with spaces. I am not an expert of OSGi, so @davsclaus waiting for your opinion about it. |
There is also a camel-hbase in the features.xml file. I wonder if that needs any adjustments? You can test it that works by running CamelHbaseTest in the tests/camel-itest-karaf directory. |
The unit tests of camel-hbase fails, do they work for you?
|
I have upgraded camel-hdfs2 to the newer hadoop2 version. There was also a change needed for osgi users. |
And btw looks like there is hbase 1.1.2 out |
Hi @davsclaus ! I'll check karaf tests and also look at camel-hdfs2 project. Right, HBase 1.1.2 is out, but currenly not attached to any distribution of Hadoop platform (neither Hortonworks nor Cloudera) |
The tests works on the old version |
do you type just mvn test in camel-hbase directory? In my case such tests pass because minicluster cannot be started. |
Ah sorry yeah those tests are skipped locally, would need a hbase cluster. I guess you need to setup that manually. Though the test should pass running locally build or skip the tests in a maven setting in the pom.xml, and have a profile for running integration tests. There is some other components doing that, such as camel-twitter that has both unit tests and integration with a profile. |
Hi! So far I spotted a inconsistency in documentation. There are two parameters of hbase-consumer in documentation http://camel.apache.org/hbase.html no longer available in the component: initialDelay, delay. When I tried to use it as a parameter of a hbase-consumer I had an error ("unrecognized parameter" or something). Still debugging. |
In case of HBaseConsumerTest.testPutMultiRowsAndConsume |
You are welcome to what you feel the best. If an update + this change is needed together then one PR is fine. We would like to upgrade hbase so eventually we would like it all sorted. |
In CamelHBaseFilterTest.createRouteBuilder I see a definition of scan operation with a param: IMO filters in camel-hbase need to be rethink. |
I've fixed tests (there was also a bug in HBaseConsumer). The last, but not least is osgi. I tried to run camel-itest-karaf, but have errors for all tests :( |
one of fails in camel-itest-karaf: |
Works for me with mvn test -Dtest=CamelAhcTest Make sure you have built all the source code, I usually do in the morning
|
thanks for commands. I used also conjars repo, the same problem. |
I just updated camel-gae to use dependencies that are downloadable from mvn central. Can you try to pull latest code from master and see if you can build Camel ? |
@davsclaus , thanks. Now camel-gae is ok, but I have the same problem with camel-example-gauth. Could you repair it too? Failed to execute goal on project camel-example-gauth: Could not resolve dependencies for project org.apache.camel:camel-example-gauth:war:2.17-SNAPSHOT: The following artifacts could not be resolved: com.google.gdata:gdata-calendar-2.0:jar:1.41.5, com.google.gdata:gdata-client-1.0:jar:1.41.5, com.google.gdata:gdata-core-1.0:jar:1.41.5: Failure to find com.google.gdata:gdata-calendar-2.0:jar:1.41.5 in https://repo.maven.apache.org/maven2 was cached in the local repository, resolution will not be reattempted until the update interval of central has elapsed or updates are forced -> [Help 1] |
ok can you try again |
Step forward. :) Another problem with dependencies: |
its osgi pulling in old JARs that are not in central. I really wonder why spring is removed from central? Anyway the example has been fixed to not do osgi as that was a bad example anyway. So please try again |
Thank you, it works now. |
The test |
Ah it passed but took a fair long time, about 5 minutes |
It's because all test cases starts a new Hadoop mini cluster.
|
Just pushed the stuff. Thanks. Can you close this PR |
Thank you too! |
Fixed CS for camel-core and camel-catalog
Before the upgrade I was not able to run tests properly, because of an error during setup of HadoopMinicluster. In that case all tests pass, but are not started. I have a linux environment.
After the update I was able to run tests. There are 18 positive results and 2 negative in my environment. I cannot check how many negative tests were on the previous versions, because of the error mentioned at the beginning.