Add new Maven profile postgres-docker #111
Conversation
* Useful to run integration tests without installed Postgres DB * Activation with `-DcayenneTestConnection=postgres-docker` * Starts Postgres Docker container before integration test and stops if afterwards * Sets JDBC connection properties based on dynamic Docker container port allocation
|
Nice! Wondering why do we need this profile declaration in submodules (cayenne-server, cayenne-client). Regular postgres profile is only declared at the top level. This seems to be sufficient. |
|
Yes, it works when putting the "executions" to the parent pom. However then the Postgres Docker container would be started and stopped for each submodule, even for those that don't have any integration tests and don't need a running database. This would slow down the build by 2-5 seconds per module. As the two submodules run tests against a database I choosed that approach. But feel free to change. PS: The pull request is result of discussion here: https://lists.apache.org/thread.html/206a60fb8697c2bc1b7c9c44f62f9eb6a7500bb9a6b57b3bd70ebaac@%3Cbuilds.apache.org%3E |
|
Ah, good point. Our current Docker-free profiles don't need to start anything. So they are simpler. |
|
Unfortunately, there is a problem to use it on mac fabric8io/docker-maven-plugin#430 Anyway, I'll check it on Linux soon and I'll add configurations for other databases. Thanks! |
|
@thinline72, sure, closed. |
-DcayenneTestConnection=postgres-docker