Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed CAY-2379 by focusing the ObjEntity after the undo RemoveAttributeUndoableEdit Action #246

Closed
wants to merge 7 commits into from

Conversation

emecas
Copy link
Contributor

@emecas emecas commented Nov 10, 2017

Fixing CAY-2379 by focusing the ObjEntity after the undo RemoveAttributeUndoableEdit action

  • Divided and set public access to viewCounterpartEntity method in DbEntityCounterpartAction to be able to switch to the ObjEntity from RemoveAttributeUndoableEdit class.
  • Added focusObjEntity method to RemoveAttributeUndoableEdit class
  • Invoking focusObjEntity method inside undo method, in the section doing the attribute restitution for ObjEntity type

@stariy95
Copy link
Member

Hi @emecas
Thank you for bug report and especially for this PR.
Have you tried to handle focus directly in RemoveAttributeUndoableEdit class instead of CayenneUndoManager? It should be clearer in my opinion.

@emecas
Copy link
Contributor Author

emecas commented Nov 14, 2017

Hi, @stariy95

My pleasure :), thanks for your feedback. Actually it was my first attempt, but when i started playing around I observed additional bugs that pushed me to handle the focus on CayenneUndoManager, including an Exception dialog in the modeler that I have not been able to reproduce yet. I will try fix it directly in RemoveAttributeUndoableEdit level and then will back to you asap.

I'll open another issue for documenting and fixing the additional bug.

@emecas
Copy link
Contributor Author

emecas commented Nov 15, 2017

Hi @stariy95 , last commit fixes CAY-2379, handling focus directly in RemoveAttributeUndoableEdit class.

@asfgit asfgit closed this in 201ccc2 Dec 1, 2017
MegaPapa pushed a commit to MegaPapa/cayenne that referenced this pull request Mar 23, 2018
…ted ObjAttribute.

This fix is based on PR by Emerson Castaneda, with minor cleanup.
Closes apache#246
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants