Add test for db merge #9
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
AlexKolonitsky
commented
Aug 29, 2014
AlexKolonitsky
commented
- make token name a constructor parameter and remove all other implementations of this method
- I've created builders for domain objects (i.e. DataMap, Db\Obj Entity, Db\Obj Attribute, ...) and Factory for all builders; Main goal to provide easy way of construction objects and fill them partially with only data that necessary for test case, everything else required to make object valid will be generated randomly.
- DbMergerTest - test correct identification of DbToModel changes
- TokensReversTest - test compliance with the invariant token.reverse.reverse == token
- TokensToModelExecution - test application correctness of DbToModel tokens
- new dependency datafactory - in order to use random data in tests where exact value not really important
…mentations of this method 2) I've created builders for domain objects (i.e. DataMap, Db\Obj Entity, Db\Obj Attribute, ...) and Factory for all builders; Main goal to provide easy way of construction objects and fill them partially with only data that necessary for test case, everything else required to make object valid will be generated randomly. 3) DbMergerTest - test correct identification of DbToModel changes 4) TokensReversTest - test compliance with the invariant token.reverse.reverse == token 5) TokensToModelExecution - test application correctness of DbToModel tokens 6) new dependency datafactory - in order to use random data in tests where exact value not really important
|
Committed in a squashed form. Good stuff! Noticed a few test failures though (on HSQL and MySQL) : Failed tests: |
|
Unit tests failures are still happening even after applying #10. However I was able to narrow it down to java 6 tests. Doesn't happen on Java 7. |
|
I've fixed tests |
|
Applied. Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.