-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Filter version comparison #432
Comments
In addition [1.5.0,2.0.0) did not match if you version is 1.10.0 . The version comparison uses a simple string compare instead of a version compare. so 1.10.0 is less than 1.5.0, but it should be greater. So at the moment 2 digit version numbers are not supported. Is this expected behavior or a bug? |
This is a bug and bug that is broader then only version, because filter comparison is always done on strings. I am currently working on this, but this will take a while because it has impact on the properties implementation, properties usage and filter implementation. |
A more local change would be to only change filter implementation. If both compare items are convertable to a version make a version compare, else make a string compare. |
i made a quick fix in celix 1.12 for me. Perhaps its a solution for current branch too?
|
Thanks @tira-misu I will take a look at this. |
It happens because celix_filter makes simple strcmp when dealing with <= and >=.
The above makes our dm_exmaple broken, i.e., phase2b's requirement is never satisfied and thus not active:
The text was updated successfully, but these errors were encountered: