Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to declare link libraries needed for containers for bundles #90

Closed
rlenferink opened this issue Sep 28, 2019 · 1 comment
Closed
Labels
build/cmake Categorizes an issue or PR relevant to the cmake build. kind/improvement Categorizes issue or PR as related to improvements.

Comments

@rlenferink
Copy link
Member

Some bundles required that the container (executable) is linked against certain libraries (e.g. libjanson, libcurl, etc). To make this process more transparent add a CMake command to declare this and update the add_celix_container functionality to take this into account.

Somethink link celix_bundle_add_container_libraries


Original creation date: 09/Apr/2018
Reporter: @pnoltes

@rlenferink rlenferink added build/cmake Categorizes an issue or PR relevant to the cmake build. kind/improvement Categorizes issue or PR as related to improvements. labels Sep 28, 2019
@rlenferink rlenferink added this to the 2.3.0 milestone Sep 28, 2019
@pnoltes pnoltes removed this from the 2.3.0 milestone Apr 3, 2023
@PengZheng
Copy link
Contributor

Now bundles does not have such requirements any longer:

  • In the build tree, BUILD_RPATH takes care of these bundle's dependencies.
  • For the installed artifacts, it's assumed that all these dependencies is installed into proper location, LD_LIBRARY_PATH is set properly, and all these bundles have been linked against their dependencies correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build/cmake Categorizes an issue or PR relevant to the cmake build. kind/improvement Categorizes issue or PR as related to improvements.
Projects
None yet
Development

No branches or pull requests

3 participants