Skip to content
This repository has been archived by the owner on Jan 20, 2021. It is now read-only.

[BUG] add ldap user button missing #847

Closed
DaanHoogland opened this issue Nov 6, 2020 · 6 comments · Fixed by #851
Closed

[BUG] add ldap user button missing #847

DaanHoogland opened this issue Nov 6, 2020 · 6 comments · Fixed by #851
Assignees
Labels
bug Something isn't working

Comments

@DaanHoogland
Copy link
Contributor

Describe the bug
when a ldap server has been configured, in the old UI a button for adding an ldap user in the account overview is shown.
image

In primate this is not the case:
image

To Reproduce
Steps to reproduce the behavior:

  1. configure an ldap server according to http://docs.cloudstack.apache.org/en/latest/adminguide/accounts.html#using-an-ldap-server-for-user-authentication
  2. login
  3. go to accounts overview
  4. considder adding an ldap user according to the oldest method; manual import

Expected behavior
a button is expected.

Screenshots
see description.

Desktop (please complete the following information):

  • OS: [e.g. Windows, Mac, iOS, Android with device/screen details if applicable]
  • Browser [e.g. chrome, safari]
  • Version [e.g. 22]

Additional context
Note that this is very minor as manual import is not the preferred way to maintain ldap users.

@DaanHoogland DaanHoogland added the bug Something isn't working label Nov 6, 2020
@utchoang
Copy link

utchoang commented Nov 9, 2020

@DaanHoogland You can find the Add LDAP Account button at the next of the Add Account button (screenshot)
image

@davidjumani
Copy link
Contributor

davidjumani commented Nov 9, 2020

@utchoang @rhtyd Would it be better to make it explicit like the add account button ?

@utchoang
Copy link

utchoang commented Nov 9, 2020

@davidjumani @rhtyd Do you think it is good?
image

@davidjumani
Copy link
Contributor

davidjumani commented Nov 9, 2020

@utchoang LGTM! @DaanHoogland ^^

@DaanHoogland
Copy link
Contributor Author

@utchoang @davidjumani , i am not partial on how it would be implemented as long as it is visible to an ignorant user looking for it. I remember some talk a while ago about making it an option after pressing the add account button. the above looks clear to the user at least.

@davidjumani
Copy link
Contributor

@utchoang Please go ahead and raise a PR for the change. Thanks

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants