listPublicIPAddresses return not filtered for current network

[DagSonsteboSB]

ISSUE TYPE

• Bug Report

COMPONENT NAME

• CloudStack GUI

CLOUDSTACK VERSION

• ACS 4.11.2

CONFIGURATION

• Advanced zone
• 2 x shared networks in "setup" state

OS / ENVIRONMENT

• N/A

SUMMARY

• GUI calls listPublicIPAddresses as follows and does not filter for current network when using the "change IP address" function:
  command=listPublicIpAddresses&response=json&allocatedonly=false&networkid=01891a96-1a86-4401-948a-ed434c5be1ba&forvirtualnetwork=false
• As a result all IP addresses from both shared networks are returned, allowing the end user to select an IP address which can not be assigned to the NIC in question
• Checking http://cloudstack.apache.org/api/apidocs-4.11/apis/listPublicIpAddresses.html it seems the parameter "networkid" is not actually implemented, however this plays out as follows:
  ** Documentation specifies this as parameter "associatednetworkid"
  ** CloudMonkey etc. will return "associatednetworkid" when querying input parameters
  ** However the API will not actually filter for "networkid" and using "associatednetworkid" returns 0 nil records, hence matching does not work

STEPS TO REPRODUCE

• Create two shared networks and make sure they are in "setup" state
• Create VM with NIC assigned to shared net 1
• Try to use the "change IP" function in the GUI
• Observe this returns a list of ALL shared IP addresses for both shared networks
• For completeness sake try to assign an IP address on the second shared network and observe this failing whether VM is running or not

EXPECTED RESULTS

• GUI should return only IP addresses on current shared network

ACTUAL RESULTS

• GUI returns list of IP addresses from both shared networks

[rohityadavcloud]

Fixed in #3368