Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CSV-150] Escaping is not disableable #68

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

dota17
Copy link
Contributor

@dota17 dota17 commented May 8, 2020

Hi, @garydgregory
In the source code, it is estimated that for performance reasons, Character is converted to char, so null is mapped to \ufffe which cannot appear in the middle of a normal file. Now if you have the \ufffe character in the middle of the file, there's a problem.

@coveralls
Copy link

coveralls commented May 8, 2020

Coverage Status

Coverage remained the same at 98.506% when pulling 304c6ef on dota17:JiraCsv150 into 852e11e on apache:master.

@garydgregory
Copy link
Member

@dota17
May you please rebase on master?

1 similar comment
@garydgregory
Copy link
Member

@dota17
May you please rebase on master?

@huxi
Copy link

huxi commented Dec 15, 2021

Looks like the tests doesn't fail in case of IOException.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants