Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unknown property gradlePluginGoogleServicesVersion #1284

Closed
3 tasks done
BmsVisionJo opened this issue Jul 19, 2021 · 0 comments · Fixed by #1287
Closed
3 tasks done

Unknown property gradlePluginGoogleServicesVersion #1284

BmsVisionJo opened this issue Jul 19, 2021 · 0 comments · Fixed by #1287
Assignees
Labels
Milestone

Comments

@BmsVisionJo
Copy link

BmsVisionJo commented Jul 19, 2021

Bug Report

Problem

When enabling the GradlePluginGoogleServicesEnabled preference the gradle build fails with the following message:

  • Where:
    Build file 'D:\Repos\MyMES\mmMobileApp\platforms\android\app\build.gradle' line: 49

  • What went wrong:
    A problem occurred evaluating project ':app'.

Could not get unknown property 'gradlePluginGoogleServicesVersion' for object of type org.gradle.api.internal.artifacts.dsl.dependencies.DefaultDependencyHandler.

What is expected to happen?

Use the correct property so the build can complete

What does actually happen?

This code has been changed to be able to pass in the config defined by the preferences.
I think that it is just a forgotten property that needs changing.
Replacing line 49 from:
if(!cdvHelpers.isVersionValid(gradlePluginGoogleServicesVersion)) {
to:
if(!cdvHelpers.isVersionValid(cordovaConfig.GRADLE_PLUGIN_GOOGLE_SERVICES_VERSION)) {
fixes the issue

Command or Code

Cordova build

Version information

Cordova android 10.0.0-nightly.2021.7.17.92864963

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@erisu erisu self-assigned this Jul 20, 2021
@erisu erisu added the bug label Jul 20, 2021
@erisu erisu added this to the 10.0.1 milestone Jul 20, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants