Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

<uses-sdk> tag is not added to AndroidManifest.xml as expected #923

Closed
3 tasks done
penguin-debug opened this issue Mar 6, 2020 · 4 comments
Closed
3 tasks done

<uses-sdk> tag is not added to AndroidManifest.xml as expected #923

penguin-debug opened this issue Mar 6, 2020 · 4 comments
Labels
info-needed / awaiting response Further information is requested

Comments

@penguin-debug
Copy link

Bug Report

Problem

Im developing an ionic project, Android platform is added as expected when I add android platform by execute "ionic cordova platform android@8.1.0" however there are now tag such as in AndroidManifest.xml file inside platform/android/src/main folder even though I include in config.xml in the root of my project.

This is happening in cordova-android@8.1.0 but not in cordova-android@8.0.0

What is expected to happen?

tag such as is found in AndroidManifest.xml file inside platform/android/src/main folder when add android platform by execute "ionic cordova platform add android@8.1.0"

What does actually happen?

tag such as is not found in AndroidManifest.xml file inside platform/android/src/main folder when I add android platform by execute "ionic cordova platform add android@8.1.0"

Command or Code

ionic cordova platform add android@8.1.0

Version information

Ionic:

ionic (Ionic CLI) : 4.7.1 (/usr/local/lib/node_modules/ionic
Ionic Framework : ionic-angular 3.9.2
@ionic/app-scripts : 3.2.1

Cordova:

cordova (Cordova CLI) : 9.0.0 (cordova-lib@9.0.1)
Cordova Platforms : android 8.1.0, ios 5.0.0
Cordova Plugins : cordova-plugin-ionic-keyboard 2.1.3, cordova-plugin-ionic-webview 1.2.1, (and 38 other plugins)

System:

Android SDK Tools : 26.1.1 (/Users/user/Library/Android/sdk)
ios-deploy : 1.9.4
ios-sim : 7.0.0
NodeJS : v10.11.0 (/Users/user/.nvm/versions/node/v10.11.0/bin/node)
npm : 6.4.1
OS : macOS Mojave
Xcode : Xcode 11.3 Build version 11C29

Checklist

  • I searched for existing GitHub issues
  • I updated all Cordova tooling to most recent version
  • I included all the necessary information above
@jcesarmobile
Copy link
Member

What do you have in the config.xml?

@jcesarmobile jcesarmobile added the info-needed / awaiting response Further information is requested label Mar 12, 2020
@penguin-debug
Copy link
Author

Here is the config.xml :

<?xml version='1.0' encoding='utf-8'?>
<widget android-versionCode="30000" id="com.sme.app" version="3.0.0.0" xmlns="http://www.w3.org/ns/widgets" xmlns:cdv="http://cordova.apache.org/ns/1.0">
    <name>App</name>
    <description>An awesome Ionic/Cordova app.</description>
    <author email="hi@ionicframework" href="http://ionicframework.com/">Ionic Framework Team</author>
    <content src="index.html" />
    <access launch-external="yes" origin="*" />
    <access origin="cdvfile://*" />
    <allow-intent href="http://*/*" />
    <allow-intent href="https://*/*" />
    <allow-intent href="tel:*" launch-external="yes" />
    <allow-intent href="sms:*" />
    <allow-intent href="mailto:*" />
    <allow-intent href="geo:*" />
    <allow-intent href="cdvfile://*" />
    <allow-navigation href="*" />
    <preference name="WKWebViewOnly" value="true" />
    <preference name="ScrollEnabled" value="false" />
    <preference name="android-minSdkVersion" value="21" />
    <preference name="BackupWebStorage" value="none" />
    <preference name="SplashMaintainAspectRatio" value="true" />
    <preference name="FadeSplashScreenDuration" value="300" />
    <preference name="SplashShowOnlyFirstTime" value="false" />
    <preference name="SplashScreen" value="screen" />
    <preference name="SplashScreenDelay" value="3000" />
    <preference name="AutoHideSplashScreen" value="false" />
    <preference name="webviewbounce" value="false" />
    <preference name="UIWebViewBounce" value="false" />
    <preference name="DisallowOverscroll" value="true" />
    <preference name="Orientation" value="portrait" />
    <preference name="iosPersistentFileLocation" value="Library" />
    <preference name="loglevel" value="ERROR" />
    <preference name="CordovaWebViewEngine" value="CDVWKWebViewEngine" />
    <preference name="KeyboardDisplayRequiresUserAction" value="false" />
    <preference name="AllowInlineMediaPlayback" value="true" />
    <preference name="cordova.plugins.diagnostic.modules" value="CAMERA" />
    <platform name="android">
        <preference name="AndroidLaunchMode" value="singleTask" />
        <allow-intent href="market:*" />
        <icon density="ldpi" src="resources/android/icon/drawable-ldpi-icon.png" />
        <icon density="mdpi" src="resources/android/icon/drawable-mdpi-icon.png" />
        <icon density="hdpi" src="resources/android/icon/drawable-hdpi-icon.png" />
        <icon density="xhdpi" src="resources/android/icon/drawable-xhdpi-icon.png" />
        <icon density="xxhdpi" src="resources/android/icon/drawable-xxhdpi-icon.png" />
        <icon density="xxxhdpi" src="resources/android/icon/drawable-xxxhdpi-icon.png" />
        <splash density="land-ldpi" src="resources/android/splash/drawable-land-ldpi-screen.png" />
        <splash density="land-mdpi" src="resources/android/splash/drawable-land-mdpi-screen.png" />
        <splash density="land-hdpi" src="resources/android/splash/drawable-land-hdpi-screen.png" />
        <splash density="land-xhdpi" src="resources/android/splash/drawable-land-xhdpi-screen.png" />
        <splash density="land-xxhdpi" src="resources/android/splash/drawable-land-xxhdpi-screen.png" />
        <splash density="land-xxxhdpi" src="resources/android/splash/drawable-land-xxxhdpi-screen.png" />
        <splash density="port-ldpi" src="resources/android/splash/drawable-port-ldpi-screen.png" />
        <splash density="port-mdpi" src="resources/android/splash/drawable-port-mdpi-screen.png" />
        <splash density="port-hdpi" src="resources/android/splash/drawable-port-hdpi-screen.png" />
        <splash density="port-xhdpi" src="resources/android/splash/drawable-port-xhdpi-screen.png" />
        <splash density="port-xxhdpi" src="resources/android/splash/drawable-port-xxhdpi-screen.png" />
        <splash density="port-xxxhdpi" src="resources/android/splash/drawable-port-xxxhdpi-screen.png" />
        <resource-file src="google-services.json" target="app/google-services.json" />
        <edit-config file="app/src/main/AndroidManifest.xml" mode="merge" target="/manifest/application" xmlns:android="http://schemas.android.com/apk/res/android">
            <application android:allowBackup="false" android:fullBackupOnly="false" android:networkSecurityConfig="@xml/network_security_config" />
        </edit-config>
        <resource-file src="network_security_config.xml" target="app/src/main/res/xml/network_security_config.xml" />
    </platform>
    <platform name="ios">
        <resource-file src="GoogleService-Info.plist" />
        <allow-intent href="itms:*" />
        <allow-intent href="itms-apps:*" />
        <preference name="StatusBarOverlaysWebView" value="false" />
        <icon height="57" src="resources/ios/icon/icon.png" width="57" />
        <icon height="114" src="resources/ios/icon/icon@2x.png" width="114" />
        <icon height="40" src="resources/ios/icon/icon-40.png" width="40" />
        <icon height="80" src="resources/ios/icon/icon-40@2x.png" width="80" />
        <icon height="120" src="resources/ios/icon/icon-40@3x.png" width="120" />
        <icon height="50" src="resources/ios/icon/icon-50.png" width="50" />
        <icon height="100" src="resources/ios/icon/icon-50@2x.png" width="100" />
        <icon height="60" src="resources/ios/icon/icon-60.png" width="60" />
        <icon height="120" src="resources/ios/icon/icon-60@2x.png" width="120" />
        <icon height="180" src="resources/ios/icon/icon-60@3x.png" width="180" />
        <icon height="72" src="resources/ios/icon/icon-72.png" width="72" />
        <icon height="144" src="resources/ios/icon/icon-72@2x.png" width="144" />
        <icon height="76" src="resources/ios/icon/icon-76.png" width="76" />
        <icon height="152" src="resources/ios/icon/icon-76@2x.png" width="152" />
        <icon height="167" src="resources/ios/icon/icon-83.5@2x.png" width="167" />
        <icon height="29" src="resources/ios/icon/icon-small.png" width="29" />
        <icon height="58" src="resources/ios/icon/icon-small@2x.png" width="58" />
        <icon height="87" src="resources/ios/icon/icon-small@3x.png" width="87" />
        <icon height="1024" src="resources/ios/icon/icon-1024.png" width="1024" />
        <splash height="1136" src="resources/ios/splash/Default-568h@2x~iphone.png" width="640" />
        <splash height="1334" src="resources/ios/splash/Default-667h.png" width="750" />
        <splash height="2208" src="resources/ios/splash/Default-736h.png" width="1242" />
        <splash height="2436" src="resources/ios/splash/Default-Portrait-1125h@3x.png" width="1125" />
        <splash height="2436" src="resources/ios/splash/Default-Portrait-2436h@3x.png" width="1125" />
        <splash height="1792" src="resources/ios/splash/Default-Portrait-1792h@2x.png" width="828" />
        <splash height="2688" src="resources/ios/splash/Default-Portrait-2688h@3x.png" width="1242" />
        <splash height="1242" src="resources/ios/splash/Default-Landscape-736h.png" width="2208" />
        <splash height="1536" src="resources/ios/splash/Default-Landscape@2x~ipad.png" width="2048" />
        <splash height="2048" src="resources/ios/splash/Default-Landscape@~ipadpro.png" width="2732" />
        <splash height="768" src="resources/ios/splash/Default-Landscape~ipad.png" width="1024" />
        <splash height="2048" src="resources/ios/splash/Default-Portrait@2x~ipad.png" width="1536" />
        <splash height="2732" src="resources/ios/splash/Default-Portrait@~ipadpro.png" width="2048" />
        <splash height="1024" src="resources/ios/splash/Default-Portrait~ipad.png" width="768" />
        <splash height="960" src="resources/ios/splash/Default@2x~iphone.png" width="640" />
        <splash height="480" src="resources/ios/splash/Default~iphone.png" width="320" />
        <splash height="1366" src="resources/ios/splash/Default@1x~universal~anyany.png" width="1366" />
        <splash height="2732" src="resources/ios/splash/Default@2x~universal~anyany.png" width="2732" />
        <splash height="5464" src="resources/ios/splash/Default@3x~universal~anyany.png" width="5464" />
        <splash height="2436" src="resources/ios/splash/Default-Portrait-2436h@3x.png" width="1125" />
        <splash height="1125" src="resources/ios/splash/Default-Landscape-2436h@3x.png" width="2436" />
        <custom-config-file mode="merge" parent="NSAppTransportSecurity" target="*-Info.plist">
            <dict>
                <key>NSAllowsArbitraryLoads</key>
                <true />
            </dict>
        </custom-config-file>
        <custom-config-file mode="merge" parent="UILaunchStoryboardName" target="*-Info.plist">
            <string>CDVLaunchScreen</string>
        </custom-config-file>
        <edit-config file="*-Info.plist" mode="merge" target="NSFaceIDUsageDescription">
            <string>This will help you quickly login in the future.</string>
        </edit-config>
        <allow-navigation href="http://localhost:8001/*" />
        <preference name="WKPort" value="8001" />
    </platform>
    <plugin name="cordova-plugin-advanced-http" spec="./local_plugins/cordova-plugin-advanced-http/1.11.1/cordova-plugin-advanced-http" />
    <plugin name="cordova-plugin-networkinterface" spec="2.0.0" />
    <plugin name="cordova-plugin-iroot" spec="0.8.1">
        <variable name="ENABLE_BUSYBOX_CHECK" value="true" />
    </plugin>
    <plugin name="cordova-custom-config" spec="5.1.0" />
    <plugin name="cordova-plugin-proguard" spec="./local_plugins/cordova-plugin-proguard/2.0.0/cordova-plugin-proguard" />
    <plugin name="cordova-plugin-whitelist" spec="1.3.3" />
    <plugin name="cordova-plugin-statusbar" spec="2.4.2" />
    <plugin name="cordova-plugin-device" spec="2.0.2" />
    <plugin name="cordova-plugin-splashscreen" spec="5.0.2" />
    <plugin name="cordova-plugin-ionic-keyboard" spec="2.1.3" />
    <plugin name="cordova-plugin-file" spec="6.0.1" />
    <plugin name="cordova-plugin-health" spec="./local_plugins/cordova-plugin-health/1.1.0/cordova-plugin-health">
        <variable name="HEALTH_READ_PERMISSION" value="App needs read access" />
        <variable name="HEALTH_WRITE_PERMISSION" value="App needs write access" />
    </plugin>
    <plugin name="cordova-plugin-privacyscreen" spec="./local_plugins/cordova-plugin-privacyscreen/0.3.1/cordova-plugin-privacyscreen" />
    <plugin name="cordova-plugin-app-version" spec="0.1.9" />
    <plugin name="cordova-plugin-x-toast" spec="2.7.2" />
    <plugin name="cordova-plugin-x-socialsharing" spec="5.4.4">
        <variable name="ANDROID_SUPPORT_V4_VERSION" value="24.1.1+" />
    </plugin>
    <plugin name="phonegap-plugin-barcodescanner" spec="8.0.1">
        <variable name="ANDROID_SUPPORT_V4_VERSION" value="27.+" />
    </plugin>
    <plugin name="cordova-plugin-file-transfer" spec="1.7.1" />
    <plugin name="cordova-plugin-vibration" spec="3.1.0" />
    <plugin name="cordova-plugin-secure-storage" spec="git://github.com/mibrito707/cordova-plugin-secure-storage.git#v4.0.0-beta" />
    <plugin name="cordova-open-native-settings" spec="1.5.2" />
    <plugin name="cordova-plugin-fingerprint-aio" spec="./local_plugins/cordova-plugin-fingerprint-aio/1.7.0/cordova-plugin-fingerprint-aio" />
    <plugin name="adobe-mobile-services" spec="file:local_plugins/adobe-mobile-services-plugin/4.13.1-uat/adobe-mobile-services" />
    <plugin name="cordova-plugin-firebase-analytics" spec="./local_plugins/cordova-plugin-firebase-analytics/4.0.1/cordova-plugin-firebase-analytics" />
    <plugin name="cordova-plugin-idfa" spec="./local_plugins/cordova-plugin-idfa/1.1.0/cordova-plugin-idfa">
        <variable name="PLAY_SERVICES_ADS_VERSION" value="15.+" />
    </plugin>
    <plugin name="cordova-plugin-market" spec="1.2.0" />
    <plugin name="cordova-plugin-tapjackingprotection" spec="0.1.1" />
    <plugin name="com.wopo.shealth" spec="./local_plugins/com.wopo.shealth" />
    <plugin name="cordova-plugin-androidx" spec="1.0.2" />
    <plugin name="cordova-plugin-androidx-adapter" spec="1.1.0" />
    <plugin name="cordova-android-play-services-gradle-release" spec="4.0.0">
        <variable name="PLAY_SERVICES_VERSION" value="12.+" />
    </plugin>
    <plugin name="cordova-android-firebase-gradle-release" spec="4.0.0">
        <variable name="FIREBASE_VERSION" value="12.+" />
    </plugin>
    <plugin name="cordova-plugin-appavailability" />
    <plugin name="cordova.plugins.diagnostic" spec="4.0.8" />
    <plugin name="phonegap-plugin-push" spec="file:local_plugins/phonegap-plugin-push/2.2.3/phonegap-plugin-push">
        <variable name="FCM_VERSION" value="17.3.2" />
        <variable name="ANDROID_SUPPORT_V13_VERSION" value="27.+" />
    </plugin>
</widget>

@breautek
Copy link
Contributor

I don't see any <edit-config> blocks that warrants adding uses-sdk to your manifest. What makes you think you should see a uses-sdk in the manifest?

The uses-sdk block was specifically removed from the cordova template in 8.1.0 as per #699

@erisu
Copy link
Member

erisu commented Jul 21, 2021

As pointed out, the uses-sdk blocks were removed from the AndroidManifest.xml and managed in the Gradle build scripts.

If you need to change the SDKs, try using the preference options that are documented here: https://cordova.apache.org/docs/en/10.x/config_ref/index.html#preference

@erisu erisu closed this as completed Jul 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
info-needed / awaiting response Further information is requested
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@erisu @jcesarmobile @breautek @penguin-debug