refactor!: Remove scrollView category extension on UIView #1400
+0
−24
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1400 +/- ##
=======================================
Coverage 78.25% 78.25%
=======================================
Files 15 15
Lines 1789 1789
=======================================
Hits 1400 1400
Misses 389 389 ☔ View full report in Codecov by Sentry. |
jcesarmobile
approved these changes
Feb 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🚨 BREAKING API CHANGE!
This should be tested with all the core plugins, just in case any of them are relying on this API existing.
Platforms affected
iOS
Motivation and Context
As mentioned in #1399, this API was added as a compatibility shim at the time we supported both UIWebView and WKWebView, when WKWebView did not expose a public
scrollViewproperty. That property was made available in iOS 8, and this extension now risks causing problems due to being applied globally to all UIView subclasses.Closes #1399.
Description
Remove the category extension to expose a
scrollViewproperty on all UIView object instances.Testing
...
Checklist