Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CDVWebViewUIDelegate should take a CDVViewController #1429

Open
dpogue opened this issue Apr 26, 2024 · 0 comments
Open

CDVWebViewUIDelegate should take a CDVViewController #1429

dpogue opened this issue Apr 26, 2024 · 0 comments
Milestone

Comments

@dpogue
Copy link
Member

dpogue commented Apr 26, 2024

Feature Request

Motivation Behind Feature

CDVWebViewUIDelegate handles a bunch of interactions with the UI and view controllers, and currently doesn't have a pointer to the CDVViewController that owns its associated WKWebView.

Feature Description

Provide an initializer for CDVWebViewUIDelegate that takes the CDVViewController and holds a weak reference to it.

Alternatives or Workarounds

We make some unsafe assumptions like the root view controller being safe to access, which has led to issues such as #1120. By having a reference to the CDVViewController we could ensure that any popups are correctly triggered by that view controller.

@dpogue dpogue added this to the 8.0.0 milestone Apr 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant