Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Promise.try polyfill #713

Closed
dpogue opened this issue Oct 2, 2018 · 3 comments
Closed

Add Promise.try polyfill #713

dpogue opened this issue Oct 2, 2018 · 3 comments
Labels
enhancement hacktoberfest Good issues to be tackled by newcomers as part of Hacktoberfest

Comments

@dpogue
Copy link
Member

dpogue commented Oct 2, 2018

There are a bunch of places that we're using a pattern like return Promise.resolve().then(...) which has a very slight async penalty and can make stacktraces a bit harder to read.

We should replace these with a Promise.try polyfill, like proposal-promise-try or p-try.

@dpogue dpogue added enhancement hacktoberfest Good issues to be tackled by newcomers as part of Hacktoberfest labels Oct 2, 2018
@xeoneux
Copy link

xeoneux commented Oct 2, 2018

I'd like to give it a try

@raphinesse
Copy link
Contributor

Once we drop support for Node.js 6 it's probably better to use async functions instead of any Promise.try implementation.

@raphinesse
Copy link
Contributor

Closing in favor of apache/cordova#175

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement hacktoberfest Good issues to be tackled by newcomers as part of Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants