Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CameraProxy.js #284

Merged
merged 1 commit into from
May 24, 2018
Merged

Update CameraProxy.js #284

merged 1 commit into from
May 24, 2018

Conversation

ZenPylon
Copy link
Contributor

Remove audio flag from getUserMedia on the browser. Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.

Platforms affected

What does this PR do?

What testing has been done on this change?

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

Remove audio flag from getUserMedia on the browser.  Including audio resulted in some nasty audio feedback, and audio isn't really needed for taking pictures anyway.
@MichaelAvellone
Copy link

I am using this plugin as well and would appreciate this change.

@shazron
Copy link
Member

shazron commented May 21, 2018

Not sure why there are massive npm errors. Close and reopen this PR to poke Travis to run it again.

@ZenPylon ZenPylon closed this May 23, 2018
@ZenPylon ZenPylon reopened this May 23, 2018
@ZenPylon
Copy link
Contributor Author

Ok, just closed and reopened!

@shazron
Copy link
Member

shazron commented May 24, 2018

Still stuck. Will close and re-open again, sigh

@shazron shazron closed this May 24, 2018
@shazron shazron reopened this May 24, 2018
@shazron
Copy link
Member

shazron commented May 24, 2018

Lol, now Appveyor passes but Travis has one build in its matrix that does not (looks to be a too many accesses error, needs an npm update). Since the previous build Travis passed, but AppVeyor failed, I'll treat this as a CI quirk

@shazron shazron merged commit 36343a8 into apache:master May 24, 2018
@alsorokin
Copy link
Contributor

Shaz, I believe you should be able to restart Travis jobs one by one.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants