Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-376 (ios) fixes UIImagePickerController cancel handling for iOS11+ #377

Merged
merged 1 commit into from
Dec 16, 2018

Conversation

easywasdev
Copy link
Contributor

Platforms affected

iOS

What does this PR do?

Fix this issue
#376

What testing has been done on this change?

Tested on a number of different iOS devices with different iOS versions (10, 11 12)
Automated tests

Checklist

  • Reported an issue in the JIRA database
  • Commit message follows the format: "CB-3232: (android) Fix bug with resolving file paths", where CB-xxxx is the JIRA ID & "android" is the platform affected.
  • Added automated test coverage as appropriate for this change.

@janpio
Copy link
Member

janpio commented Nov 20, 2018

Thanks. Can you explain what the change does and why it works and is needed?

@easywasdev
Copy link
Contributor Author

easywasdev commented Nov 20, 2018

Sure: it adds a test that only checks authorisation status if the iOS version is less than iOS 11 when the user cancels the UIImagePIckerController. Apple stopped requiring permission for this from iOS 11 and upwards so returning the "has no access to assets" error is not correct anymore. It's fully detailed in the linked issue

@janpio
Copy link
Member

janpio commented Nov 20, 2018

(Sorry for not reading that. Or better: Not understanding that this is the reason for this code change)

@janpio janpio added this to 🐣 New PR / Untriaged in Apache Cordova: Plugin Pull Requests Dec 8, 2018
Apache Cordova: Plugin Pull Requests automation moved this from 🐣 New PR / Untriaged to ✅ Approved, waiting for Merge Dec 16, 2018
Copy link
Member

@jcesarmobile jcesarmobile left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jcesarmobile jcesarmobile merged commit 24c8b6c into apache:master Dec 16, 2018
Apache Cordova: Plugin Pull Requests automation moved this from ✅ Approved, waiting for Merge to 🏆 Merged, waiting for Release Dec 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Apache Cordova: Plugin Pull Requests
🏆 Merged, waiting for Release
Development

Successfully merging this pull request may close these issues.

None yet

3 participants