Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(Android) Fix NullPointerException error on some Android phones #429

Merged
merged 1 commit into from
May 5, 2019

Conversation

hazems
Copy link
Member

@hazems hazems commented Mar 1, 2019

Platforms affected

Android

Motivation and Context

Fix NullPointerException error on some Android phones.

Description

In some Android phones, mimeType is returned as null, this is why a NullPointerException is thrown. This defect is reported by issue #400

Solution

Add a safe null checking before equalsIgnoreCase.

Checklist

  • I've run the tests to see all new and existing tests pass
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))

Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@timbru31 timbru31 requested a review from janpio May 5, 2019 14:13
@janpio janpio merged commit 295e928 into apache:master May 5, 2019
@robwatt
Copy link

robwatt commented May 10, 2019

When can we expect a new build of this plugin with this fix in it? The "latest" build is over a year old.

@janpio
Copy link
Member

janpio commented May 10, 2019

In the next few weeks or months.

@rodrigograca31
Copy link

@robwatt there's a fresh release!

@janpio
Copy link
Member

janpio commented Jun 29, 2019

Just a tag for now, release is in vote but will follow soon-ish. Watch for the rel/x.y.z tag that is made after it has been published to npm.

chintan13 added a commit to logisticinfotech/cordova-plugin-camera that referenced this pull request Sep 30, 2019
* commit 'a9436b1a185b37269366ec3e2c5f337fb14cba61':
  ImagePicker returning same image (apache#306)
  chore(release): 4.1.1-dev
  chore(release): 4.1.0 (version string)
  chore(release): release notes for 4.1.0
  docs: remove outdated test docs translations
  build: remove `.ratignore` file that is not needed any more
  chore: fix repo and issue urls and license in package.json and plugin.xml
  fix: temporarily remove Appium tests (apache#468)
  ci(travis): Update Travis CI configuration for new paramedic (apache#455)
  (Android) Fix NullPointerException error on some Android phones (apache#429)
  Update CI Environment Setup for Node.js 6 (apache#438)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants