Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Contact updates of the arrays (phoneNumbers, addresses, urls) ignored on iOS #201

Closed
Bramzor opened this issue Dec 24, 2018 · 8 comments
Closed

Comments

@Bramzor
Copy link

Bramzor commented Dec 24, 2018

I tried updating contact information on iOS using the plugin and it worked for strings but once I tried to modify array types, it was actually just ignored in the update.
After searching a bit further, I noticed that when I did put a breakpoint in the ios code, it worked but when removing that breakpoint again, it failed. Which made me conclude that its some kind of race condition.
Now I wonder if this issue is Ionic related or not. Not that Ionic does a lot with the contacts itself, it basically just allows Typescripting etc.

Anyone using this plugin with Ionic which notices the same issues?

@ppetree
Copy link

ppetree commented Jan 18, 2019

If you look at the iOS log files I bet you will find a bunch of deprecation notices. Scan for CDVcontact.h and you'll find a whole bunch of stuff was deprecated starting with iOS9.0 and the authors of this never thought of updating this stuff when iOS 9.0 was released back in 2015.

@Bramzor
Copy link
Author

Bramzor commented Jan 18, 2019

Currently there is no alternative so we are stuck with it and I'm pretty sure its a small issue as I found out that it works when I place a breakpoint in the native code so it seems some kind of race condition. So thats not related to all the deprecation notices or old code, it's just a bug.

@janpio
Copy link
Member

janpio commented Jan 18, 2019

Deprecation notices are never the source for a bug - they are just notices, that something might be removed in the future. They cause absolutely no harm, so your observation @Bramzor is not surprising.

@Bramzor
Copy link
Author

Bramzor commented Jan 18, 2019

But no one that uses this plugin and modifies these arrays just to confirm they have the same behavior on iOS?

@ppetree
Copy link

ppetree commented Jan 18, 2019

This plugin is not returning email addresses on iOS 11.x (haven't tested on 9/10/12 yet) and seems to be ignoring that little part where it just returns the fields you want.

@janpio Yeah, buy me a nice new Macbook Pro, install xCode and get Cordova apps compiling (for both platforms) and then ship the box to me and I'll fix all those niggling little bugs. ;-) Until then, I think the project I'm investigating may be my first Flutter project.

@Bramzor
Copy link
Author

Bramzor commented Jan 18, 2019

This plugin is not returning email addresses on iOS 11.x (haven't tested on 9/10/12 yet) and seems to be ignoring that little part where it just returns the fields you want.

Think you might be doing something wrong. Just checked logs and I do get email addresses on iOS 11.2 , same for iOS 12.1 . The problem is not retrieving information because all of that works. It is just when you try to UPDATE an array these updates are just ignored when I run it without a breakpoint. I work around the issue currently by removing a contact and inserting a clone of that contact again but I can only do that for new contacts as the clone itself might not have all the information the contact had.

So conclusion is that UPDATE functionality is currently broken in the plugin on iOS (havent tested it specifically on Android). Combination CREATE & REMOVE works but not ideal. We really need to get it fixed.

@ppetree
Copy link

ppetree commented Jan 18, 2019

Ok, I'll double check what I'm doing in my code... I don't need to update any information, just let grandma and grandpa pick their next of kin.

@timbru31
Copy link
Member

timbru31 commented Jan 9, 2023

We are archiving this repository following Apache Cordova's Deprecation Policy. We will not continue to work on this repository. Therefore all issues and pull requests are being closed. Thanks for your contribution.

@timbru31 timbru31 closed this as completed Jan 9, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

4 participants