Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GH-122 android: Cleanup Dialog plugin code #123

Merged
merged 1 commit into from
Mar 5, 2019

Conversation

hazems
Copy link
Member

@hazems hazems commented Mar 3, 2019

Platforms affected

Android

Description

  1. Organizing Notification imports.
  2. Externalizing Action strings in private static finals.
  3. Externalizing Beep timeout and wait time in private static finals.

Testing

Test plugin and everything works fine.

  • I've run the tests to see all new and existing tests pass
  • Commit is prefixed with (platform) if this change only applies to one platform (e.g. (android))
  • If this Pull Request resolves an issue, I linked to the issue in the text above (and used the correct keyword to close issues using keywords)

@janpio janpio merged commit 419a838 into apache:master Mar 5, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants