Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention 2 lines content limit #125

Merged
merged 1 commit into from Jun 18, 2019
Merged

docs: mention 2 lines content limit #125

merged 1 commit into from Jun 18, 2019

Conversation

hazems
Copy link
Member

@hazems hazems commented Mar 3, 2019

Description

We need to explicitly mention the dialog title behavior on Android platform to properly set user expectation.

Checklist

  • I've run the tests to see all new and existing tests pass
  • I've updated the documentation if necessary

@hazems hazems mentioned this pull request Mar 3, 2019
Closed
janpio
janpio reviewed Mar 5, 2019
View reviewed changes
README.md Show resolved Hide resolved
timbru31
timbru31 approved these changes May 6, 2019
View reviewed changes
Copy link
Member

@timbru31 timbru31 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@janpio janpio changed the title GH-124 all: Updating documentation with Android Dialog Title Behavior docs: mention 2 lines content limit Jun 18, 2019
@janpio janpio merged commit 292e13a into apache:master Jun 18, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@janpio janpio janpio left review comments

@timbru31 timbru31 timbru31 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@hazems @janpio @timbru31