Add CaptureError.CAPTURE_PERMISSION_DENIED to type declaration file #98
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A single build failed with the following error: This has nothing to do with the single line change to the TypeScript file. |
janpio
reviewed
Aug 20, 2018
types/index.d.ts
Outdated
| @@ -123,6 +123,7 @@ declare var CaptureError: { | |||
| CAPTURE_INVALID_ARGUMENT: number; | |||
| CAPTURE_NO_MEDIA_FILES: number; | |||
| CAPTURE_NOT_SUPPORTED: number; | |||
| CAPTURE_PERMISSION_DENIED: number; | |||
There was a problem hiding this comment.
Could you fix the indentation to 4 spaces similar to the other definitions?
janpio
approved these changes
Aug 20, 2018
|
@janpio are you planning to merge in the pull request? |
|
Normally not as tests are failing (because of unrelated reasons I guess) and I am not really a programmer, but this looks safe. Thanks for the PR 🥇 💯 |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/larrybahr/cordova-plugin-media-capture#constants
Platforms affected
None
What does this PR do?
Remove a TypeScript Error
What testing has been done on this change?
Transpiled a TypeScript project with no errors.