This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 172
prepare fails on unknown splashscreen #299
Comments
I just raised PR #301 which should resolve this issue. Long term solution (in a major release) may be to drop the lines after "Fall back on find by size for old non-MRT syntax" in |
P.S. This issue was introduced in 973fe6d. |
@goya Do you still know how to recreate this? It would be best if we could add a test case on our side to avoid this popping up again. |
you can repro it now using: <?xml version='1.0' encoding='utf-8'?>
<widget id="io.cordova.hellocordova" version="1.0.0">
<name>HelloCordova</name>
<splash src="splash.jpg" width="7000" height="1200" />
</widget> n.b. the splash file must exist |
Confirmed fixed:
But tbh no idea how to turn this into a test. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
If targetImg is null it blows up and fails the prepare action. it should just return.
cordova-windows/template/cordova/lib/prepare.js
Line 513 in d424e99
The text was updated successfully, but these errors were encountered: