@purplecabbage I guess a PR can't hurt, either, eh?

@gabrielschulhof
Can you provide a test case that demonstrates the issue?
I thought this would do it, but it seems to load regardless of whether the patch is applied.

        var xhr = new XMLHttpRequest();
        xhr.onload = function () {
            console.log("loaded");
        }
        var loc = window.location.toString() + "#Hoopla";
        xhr.open("GET", loc, true);
        xhr.send();

That does indeed work. What doesn't work is xhr.open( "GET", "x-wmapp0:/www/some-other-file.html", true); even if the file is present. The leading slash is causing a 404. Basically, this code is only strips off the leading slash and only performs the path juggling if you have absolute URLs that do not include the protocol. If the URL includes the protocol, then all that code is bypassed. My modification would first strip off the protocol so that that code can do its magic.

So, there are (probably more than) three cases when retrieving a local file via Ajax:

other-file.html

works, because the URL is correctly assembled by Cordova

x-wmapp0:www/other-file.html

works, because the Uri class used here seems to understand this kind of URL

x-wmapp0:/www/other-file.html

doesn't work, because the code I mention in my previous comment is not having an effect due to the fact that the URL starts with the protocol

Now, granted, the form x-wmapp0:/www/other.html may not occur much in the wild, but performing URL calculations such as creating an absolute URL from a relative URL are impossible when the URL scheme does not have a slash at the root, because you cannot distinguish an absolute URL from a relative URL.

Thanks. I'll add a test to spec and close this up today.

Sent from my iPhone

On Mar 19, 2014, at 7:42 AM, gabrielschulhof notifications@github.com wrote:

So, there are (probably more than) three cases when retrieving a local file via Ajax:

other-file.html
works, because the URL is correctly assembled by Cordova
x-wmapp0:www/other-file.html
works, because the Uri class used here seems to understand this kind of URL
x-wmapp0:/www/other-file.html
doesn't work, because the code I mention in my previous comment is not having an effect due to the fact that the URL starts with the protocol
Now, granted, the form x-wmapp0:/www/other.html may not occur much in the wild, but performing URL calculations such as creating an absolute URL from a relative URL are impossible when the URL scheme does not have a slash at the root, because you cannot distinguish an absolute URL from a relative URL.

—
Reply to this email directly or view it on GitHub.

Thanks!