2906 couchjs sm version #2911
Merged
2906 couchjs sm version #2911
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t /etc/vm.args; also parses name from config.
|
this is good! IIRC the 60 side can also build against 68, so we need to be a little bit smarter there. Or we are more lazy and make it |
|
@janl Nope, we ended up having to fork, so the |
|
wait., when I looked there was no diff for /68, did this get added behind my back or did I just miss this earlier? Apologies! |
In couchjs -h replaced the link to jira with a link to github
Update bug request in rebar.config.script for couchjs -h
wohali
approved these changes
May 30, 2020
dottorblaster
pushed a commit
to dottorblaster/couchdb
that referenced
this pull request
Jun 19, 2020
Closes apache#2906 * Added a suffix to the first line of couchjs with the (static) version number compiled * Update rebar.config.script * In couchjs -h replaced the link to jira with a link to github Co-authored-by: simon.klassen <simon.klassen> Co-authored-by: Jan Lehnardt <jan@apache.org
wohali
pushed a commit
that referenced
this pull request
Dec 14, 2020
Closes #2906 * Added a suffix to the first line of couchjs with the (static) version number compiled * Update rebar.config.script * In couchjs -h replaced the link to jira with a link to github Co-authored-by: simon.klassen <simon.klassen> Co-authored-by: Jan Lehnardt <jan@apache.org
wohali
added a commit
that referenced
this pull request
Dec 14, 2020
Closes #2906 * Added a suffix to the first line of couchjs with the (static) version number compiled * Update rebar.config.script * In couchjs -h replaced the link to jira with a link to github Co-authored-by: simon.klassen <simon.klassen> Co-authored-by: Jan Lehnardt <jan@apache.org Co-authored-by: Simon Klassen <6997477+sklassen@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
couchjs returns couchdb version but not the version of spidermonkey used at compile time
Since each version has it's own help.h I just added the directories version number to the end of the first line eg "(SpiderMonkey 60)"
Testing recommendations
I have compiled the code can ran couchjs -V
Related Issues or Pull Requests
This addresses issue #2906
Checklist
rel/overlay/etc/default.ini