Do not return broken processes to the query process pool #3329
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisp
requested changes
Jan 15, 2021
Previously, if an error was thrown in a `with_ddoc_proc/2` callback, the process was still returned to the process pool in the `after` clause. However, in some cases, for example when processing a _list response, the process might end up stuck in a bad state state, such that it could not be re-used anymore. In such a case, a subsequent user of that couch_js process would end up throwing an error and crashing. Fixes #2962
nickva
force-pushed
the
do_not_return_bad_os_processes_into_the_pool
branch
from
3c51d95
to
6d263ae
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, if an error was thrown in a
with_ddoc_proc/2callback, the process was still returned to the process pool in theafterclause. However, in some cases, for example when processing a_listresponse, the process mightend up stuck in a bad state state, such that it could not be re-used anymore. In such a case, a subsequent user of that
couch_jsprocess would end up throwing an error and crashing.Fixes #2962
Checklist
rel/overlay/etc/default.ini