Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move all config options out of couch_httpd_auth and httpd #3472

Closed
wohali opened this issue Mar 29, 2021 · 4 comments · Fixed by #3574 or #3583
Closed

Move all config options out of couch_httpd_auth and httpd #3472

wohali opened this issue Mar 29, 2021 · 4 comments · Fixed by #3574 or #3583

Comments

@wohali
Copy link
Member

wohali commented Mar 29, 2021

These should all be in [chttpd] now.

Similarly, the [httpd] section is very misleading in 3.x. If there is a way we can drop this entirely for 3.2 that'd be outstanding - everything that matters should be in [chttpd].

The way we've handled this transition in the past is to check both config spaces, giving priority to the new definition's location. Then in the future (4.0?) we can drop support for the old config location. So this is probably 2 PRs, one to main and one to 3.x.

@nickva
Copy link
Contributor

nickva commented Mar 29, 2021

Good idea. Those settings are all over the place currently. Some settings like max_http_request_size are in httpd section only and are re-used by chttpd handling code.

@jiahuili430
Copy link
Contributor

I will give it a try, but I'm wondering since the httpd config section is used to configure the "backend" port, and the port still looks like it's open on 3.x (verify by trying curl to: 15986). Will the port stays open in 3.2, or will we close it and only use /_node/$node/ for access?

@wohali
Copy link
Member Author

wohali commented May 6, 2021

@jiahuili430 That is only during our testing; it is not supported for production use and is disabled unless special steps are taken to enable it.

@nickva
Copy link
Contributor

nickva commented May 26, 2021

Re-opened the issue as it was closed by accident through one of the "fixes: ..." lines in the commits probably

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants