Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[3.x] Add support for Spidermonkey 78 #3500

Merged
merged 1 commit into from Apr 8, 2021
Merged

[3.x] Add support for Spidermonkey 78 #3500

merged 1 commit into from Apr 8, 2021

Conversation

wohali
Copy link
Member

@wohali wohali commented Apr 7, 2021

Good to go, got the failing test fixed. Closes #3476

/cc @janl @dch @davisp

@davisp
Copy link
Member

davisp commented Apr 7, 2021

I'm pretty sure that same test was failing the last time we updated SpiderMonkey as well. Its not the greatest test and is basically showing that SpiderMonkey's garbage collection/memory efficiency is improving. I'd be on board if we just add another test function that basically blows up with the same error code rather than relying on specific memory behavior of SpiderMonkey.

@wohali
Copy link
Member Author

wohali commented Apr 7, 2021

@davisp Yeah, it was: c4aee4d

@wohali
Copy link
Member Author

wohali commented Apr 7, 2021

Got it, this is ready for review. The test was hitting the os timeout, but the easy way to fix that is to emit anything so the Erlang side doesn't think JS is hung. I then added another 500k iterations in the loop just to be on the safe side.

@wohali wohali requested a review from janl April 8, 2021 00:24
@janl janl merged commit 1842e8c into 3.x Apr 8, 2021
@wohali wohali deleted the SM78 branch April 8, 2021 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants