Bump ibrowse to 4.4.2 + couchdb patches #3551
Conversation
rebar.config.script
Outdated
| @@ -151,7 +151,7 @@ DepDescs = [ | |||
| %% Third party deps | |||
| {folsom, "folsom", {tag, "CouchDB-0.8.3"}}, | |||
| {hyper, "hyper", {tag, "CouchDB-2.2.0-6"}}, | |||
| {ibrowse, "ibrowse", {tag, "CouchDB-4.0.1-2"}}, | |||
| {ibrowse, "ibrowse", {tag, "CouchDB-4.4.2-1"}}, | |||
There was a problem hiding this comment.
There are dragons there:
There was a problem hiding this comment.
Good idea to check. It looks it won't log unless we configure a logger in the app env:
https://github.com/apache/couchdb-ibrowse/blob/CouchDB-4.4.2-1/src/ibrowse_lib.erl#L443-L446
There was a problem hiding this comment.
@iilyak would you want to make a PR for upstream to remove that, though with the logging not configured not sure how dangerous it is still?
And we could perhaps also try to upstream the commit to scrub credentials as well. I imagine other users would want to keep credentials not showing up in the logs.
There was a problem hiding this comment.
I did more thorough review of ibrowse source code. There are couple of potential issues. 1) debug/trace mode and 2) dumping of message queue using log_msg. I do agree with you that neither of these would become a problem if we wouldn't configure logger.
nickva
force-pushed
the
bump-ibrowse-to-4.4.2-patches
branch
from
8d22a48
to
4839fb5
Compare
|
PR cmullaparthi/ibrowse#172 for upstream |
Set the `worker_trap_exits = false` setting to ensure our replication worker pool properly cleans up worker processes. Ref: #3208
nickva
force-pushed
the
bump-ibrowse-to-4.4.2-patches
branch
from
4839fb5
to
6807dcd
Compare
|
Upstream PR was merged, I created a new ibrowse + our patches release and updated the PR. It now passes the CI. |
|
@wohali waiting to resolve #3551 (comment) |
With the move from using a forked ibrowse to upstream [1], the ibrowse options for socks5 proxy settings all changed to a `socks5_` prefix. [1] #3551
With the move from using a forked ibrowse to upstream [1], the ibrowse options for socks5 proxy settings all changed to a `socks5_` prefix. [1] #3551
With the move from using a forked ibrowse to upstream [1], the ibrowse options for socks5 proxy settings all changed to a `socks5_` prefix. [1] #3551
Set the
worker_trap_exits = falsesetting to ensure our replication worker pool properly cleans up worker processes.Ref: #3208