Require Content-Type for /_session POST
#4161
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Currently, when POSTing to `/_session` with a Content-Type header other than either `application/x-www-form-urlencoded` or `application/json`, the error response can be surprising. This changes the response to 415 `bad_content_type` when it's not one of the above.
jaydoane
force-pushed
the
session-require-content-type
branch
from
b68f631
to
d9afd1d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Overview
Currently, when POSTing to
/_sessionwith aContent-Typeheader other than eitherapplication/x-www-form-urlencodedorapplication/json, the error response can be surprising.This changes the response to 415
bad_content_typewhen it's not one of the above.Testing recommendations
Related Issues or Pull Requests
Checklist
rel/overlay/etc/default.ini