Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove json2 JS script and the try except around seal #4412

Merged
merged 1 commit into from Feb 3, 2023

Conversation

nickva
Copy link
Contributor

@nickva nickva commented Feb 2, 2023

  • Remove json2 all supported runtimes have the JSON object now

  • Remove the try except for broken seal in 1.9.x we don't support 1.9.x and it worked in 1.8.x and then in 60+ (at least, we don't support anything lower).

1.8.5

% js --help 2>&1 | grep 185
  185:  JavaScript 1.8.5 (default)
% js
js>  var a=[1,2,3]; Object.freeze(a); a[1]=100; a
[1, 2, 3]

78

% js78
var a=[1,2,3]; Object.freeze(a); a[1]=100; a
[1, 2, 3]
js>

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=449657#c0

 * Remove json2 all supported runtimes have the JSON now

 * Remove the try except for broken seal in 1.9.x we don't support 1.9.x and it
   worked in 1.8.x and then in 60+ (at least, we don't support anything lower).

1.8.5
```
% js --help 2>&1 | grep 185
  185:  JavaScript 1.8.5 (default)
% js
js>  var a=[1,2,3]; Object.freeze(a); a[1]=100; a
[1, 2, 3]
```

78
```
% js78
var a=[1,2,3]; Object.freeze(a); a[1]=100; a
[1, 2, 3]
js>
```

[1] https://bugzilla.mozilla.org/show_bug.cgi?id=449657#c0
@nickva
Copy link
Contributor Author

nickva commented Feb 2, 2023

Tested it locally with 1.8.5 ./configure --dev --spidermonkey-version 1.8.5 and make check

@nickva nickva requested review from rnewson and janl February 2, 2023 19:15
@big-r81
Copy link
Contributor

big-r81 commented Feb 2, 2023

Tested it locally with 91 ./configure --dev --spidermonkey-version 91 and make check

Collections
===========

     Total    Fixture       Test      Count     Failed     Errors    Skipped
    777.5s     322.6s     454.9s       3250          0          0          0 EUnit        
    168.4s       0.0s     168.4s        538          0          0          8 EXUnit        
      0.0s       0.0s       0.0s          0          0          0          0 JavaScript        
      0.0s       0.0s       0.0s          0          0          0          0 Mango 

@janl janl merged commit 1eef739 into main Feb 3, 2023
@janl janl deleted the cleanup-up-js-scripts branch February 3, 2023 14:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants