Wait for compacted indexes to flip. #4821
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Noticed on a few production instances, we run a potentially long compaction, and when done, the call to commit the compacted state times out after 5 seconds. That, in turn, triggers are a `compaction_failed` call, which also may timeout and the whole thing crashes. Since we have the ioq scheduler running and we're doing disk IO, compaction swap may be delayed in the background, and take longer than 5 seconds. Opt to wait however long it takes or crash for some other reason. gen_server calls already auto-monitor and check for called process's exits.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Noticed on a few production instances, we run a potentially long compaction, and when done, the call to commit the compacted state times out after 5 seconds. That, in turn, triggers are a
compaction_failedcall, which also may timeout and the whole thing crashes.Since we have the ioq scheduler running and we're doing disk IO, compaction swap may be delayed in the background, and take longer than 5 seconds. Opt to wait however long it takes or crash for some other reason. gen_server calls already auto-monitor and check for called process's exits.